fix wrong order to isAssignableTo for override params

fix wrong order to isAssignableTo for override params

Also renames the easy-to-miss overridden/overriding to the more clear base/derived, so these bugs will come up less often.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/af13ca9e25be4f3b5c47794798aed17b6514a2d1

[Jennifer Messerly, 2016-08-10 23:46:47]

Description was changed from

==========
fix wrong order to isAssignableTo for override params
==========

to

==========
fix wrong order to isAssignableTo for override params

this is at least the third time I've fixed one of these, so I renamed the
easy-to-miss overridden/overriding to the more clear base/derived
==========

[Jennifer Messerly, 2016-08-10 23:50:47]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com, vsm@google.com

[Jennifer Messerly, 2016-08-10 23:50:48]

https://codereview.chromium.org/2236763002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/error_verifier.dart (right):

https://codereview.chromium.org/2236763002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/error_verifier.dart:1449: FunctionType derivedFT
= derivedElement.type;
I renamed all of these to make it much easier to eyeball which type is which.

https://codereview.chromium.org/2236763002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/2236763002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:3022:
/*error:INVALID_METHOD_OVERRIDE*/m(/*error:INVALID_METHOD_OVERRIDE_NORMAL_PARAM_TYPE*/B
b);
we should probably let error_verifier's messages replace ours. it's a bit
confusing right now we do the checking in two places. e.g. for @covariant
overrides I will have to fix both.

https://codereview.chromium.org/2236763002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:3026: check(implicitCasts:
false);
This bug wasn't visible until we turn off implicit casts. The reason is we have
our own override checking in checker.dart for strong mode, and isAssignableTo is
highly permissive even in strong mode. So we just didn't see this problem. Same
deal in Dart 1 -- the order (almost) didn't matter.

[Jennifer Messerly, 2016-08-10 23:51:21]

Description was changed from

==========
fix wrong order to isAssignableTo for override params

this is at least the third time I've fixed one of these, so I renamed the
easy-to-miss overridden/overriding to the more clear base/derived
==========

to

==========
fix wrong order to isAssignableTo for override params

Also renames the easy-to-miss overridden/overriding to the more clear
base/derived, so these bugs will come up less often.
==========

[Jennifer Messerly, 2016-08-10 23:55:10]

BTW, I found this while investigating
https://github.com/dart-lang/sdk/issues/25578

[Brian Wilkerson, 2016-08-11 00:00:18]

lgtm

[Jennifer Messerly, 2016-08-11 00:50:37]

Description was changed from

==========
fix wrong order to isAssignableTo for override params

Also renames the easy-to-miss overridden/overriding to the more clear
base/derived, so these bugs will come up less often.
==========

to

==========
fix wrong order to isAssignableTo for override params

Also renames the easy-to-miss overridden/overriding to the more clear
base/derived, so these bugs will come up less often.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/af13ca9e25be4f3b5c47794798aed17b6514a2d1
==========

[Jennifer Messerly, 2016-08-11 00:50:39]

Committed patchset #1 (id:1) manually as
af13ca9e25be4f3b5c47794798aed17b6514a2d1 (presubmit successful).