Add a PRESUBMIT check for 'printf'.

Add a PRESUBMIT check for 'printf'.

As we all know, printf debugging is best debugging. But debug code
should probably be removed before asking people to review a patch.
Otherwise you're bound to look a bit silly.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155687

[Mike West, 2013-08-06 06:50:00]

In the selfish hope that I can avoid embarrassing myself in the future, would
you mind taking a look at this patch? :)

-mike

[abarth-chromium, 2013-08-06 06:51:30]

LGTM :)

[jochen (gone - plz use gerrit), 2013-08-06 06:57:11]

that will make it impossible to add new printf debug helpers using the commit
queue, no?

[jochen (gone - plz use gerrit), 2013-08-06 06:58:36]

like here
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Mike West, 2013-08-06 07:13:53]

On 2013/08/06 06:58:36, jochen wrote:
> like here
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Yeah. I didn't realize those existed, actually. Hrm.

I could move this to CheckChangeOnUpload, I suppose. That would allow you to
easily bypass it via `--bypass-hooks`, and wouldn't run the check on the CQ. Is
that a compromise you would live with?

-mike

[abarth-chromium, 2013-08-06 07:18:29]

On 2013/08/06 07:13:53, Mike West wrote:
> On 2013/08/06 06:58:36, jochen wrote:
> > like here
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Yeah. I didn't realize those existed, actually. Hrm.
> 
> I could move this to CheckChangeOnUpload, I suppose. That would allow you to
> easily bypass it via `--bypass-hooks`, and wouldn't run the check on the CQ.
Is
> that a compromise you would live with?

Maybe this is better done in the style checker than in PRESUBMIT?

[jochen (gone - plz use gerrit), 2013-08-06 07:31:58]

as long as it doesn't break the commit queue, i'm fine with whatever solution :)

[Mike West, 2013-08-06 08:12:49]

On 2013/08/06 07:18:29, abarth wrote:
> On 2013/08/06 07:13:53, Mike West wrote:
> > On 2013/08/06 06:58:36, jochen wrote:
> > > like here
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > 
> > Yeah. I didn't realize those existed, actually. Hrm.
> > 
> > I could move this to CheckChangeOnUpload, I suppose. That would allow you to
> > easily bypass it via `--bypass-hooks`, and wouldn't run the check on the CQ.
> Is
> > that a compromise you would live with?
> 
> Maybe this is better done in the style checker than in PRESUBMIT?

There are a number of 'runtime/printf' style checks that ensure that printf is
being used correctly. The check I'm adding isn't about correct usage of printf,
but more of a sanity check to ensure you really mean to upload a patchset with
printfs. *shrug* It seems more like a presubmit check than a style check. That
said, it seems capricious to try to ban something we apparently have style rules
governing. :(

Perhaps I need to loop in blink-dev@ for bikeshedding. :)

[abarth-chromium, 2013-08-06 18:36:39]

On 2013/08/06 08:12:49, Mike West wrote:
> Perhaps I need to loop in blink-dev@ for bikeshedding. :)

I would just pick something and commit it.  If it causes problems, we can
iterate.

[Mike West, 2013-08-07 07:31:45]

On 2013/08/06 18:36:39, abarth wrote:
> On 2013/08/06 08:12:49, Mike West wrote:
> > Perhaps I need to loop in blink-dev@ for bikeshedding. :)
> 
> I would just pick something and commit it.  If it causes problems, we can
> iterate.

Good enough for me. :)

[commit-bot: I haz the power, 2013-08-07 07:34:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/22366003/11001

[commit-bot: I haz the power, 2013-08-07 11:07:00]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-08-07 11:29:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/22366003/11001

[commit-bot: I haz the power, 2013-08-07 12:14:50]

Change committed as 155687