Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2236473003: [mojo-edk] Revert ObserveProxy retransmission behavior (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Revert ObserveProxy retransmission behavior Gets rid of ObserveProxy retransmission which was only required to facilitate excessive randomization in tests. In practice this behavior can race with normal port closure and lead to busy loops. Gets rid of excessive randomization in tests. The new PortsTest environment more closely emulates reality: Nodes operate independently but there are some basic and trivially satisfiable ordering guarantees. Gets rid of deferred AcceptIncomingMessages pumping in NodeController, which was only added to facilitate ObserveProxy retransmission. BUG=628492, 635508 Review-Url: https://codereview.chromium.org/2219733005 Cr-Commit-Position: refs/heads/master@{#410535} (cherry picked from commit 36f85398960e7836d5325e1a58298209ced34f33) Committed: https://chromium.googlesource.com/chromium/src/+/573af98298255787657627c25a78a5de1676da73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+828 lines, -872 lines) Patch
M mojo/edk/system/node_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/ports/node.h View 2 chunks +10 lines, -3 lines 0 comments Download
M mojo/edk/system/ports/node.cc View 3 chunks +4 lines, -13 lines 0 comments Download
M mojo/edk/system/ports/ports_unittest.cc View 8 chunks +812 lines, -855 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ken Rockot(use gerrit already)
4 years, 4 months ago (2016-08-10 23:19:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
573af98298255787657627c25a78a5de1676da73.

Powered by Google App Engine
This is Rietveld 408576698