[mojo-edk] Revert ObserveProxy retransmission behavior

[mojo-edk] Revert ObserveProxy retransmission behavior

Gets rid of ObserveProxy retransmission which was only required
to facilitate excessive randomization in tests. In practice this
behavior can race with normal port closure and lead to busy
loops.

Gets rid of excessive randomization in tests. The new PortsTest
environment more closely emulates reality: Nodes operate
independently but there are some basic and trivially satisfiable
ordering guarantees.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController, which was only added to facilitate
ObserveProxy retransmission.

BUG=628492, 635508
Committed: https://crrev.com/36f85398960e7836d5325e1a58298209ced34f33
Cr-Commit-Position: refs/heads/master@{#410535}

[Ken Rockot(use gerrit already), 2016-08-08 18:27:02]

Description was changed from

==========
[mojo-edk] Rework ports test framework

Gets rid of unnecessarily aggressive randomization in the
test environment.

Gets rid of ObserveProxy retransmission which was only required
to facilitate aggressive randomization in tests.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController which was only added to facilitate
ObserveProxy retransmission.

BUG=None
==========

to

==========
[mojo-edk] Rework ports test framework

Gets rid of unnecessarily aggressive randomization in the
test environment.

Gets rid of ObserveProxy retransmission which was only required
to facilitate aggressive randomization in tests.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController which was only added to facilitate
ObserveProxy retransmission.

BUG=628492,635508
==========

[Ken Rockot(use gerrit already), 2016-08-08 18:28:55]

Description was changed from

==========
[mojo-edk] Rework ports test framework

Gets rid of unnecessarily aggressive randomization in the
test environment.

Gets rid of ObserveProxy retransmission which was only required
to facilitate aggressive randomization in tests.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController which was only added to facilitate
ObserveProxy retransmission.

BUG=628492,635508
==========

to

==========
[mojo-edk] Revert ObserveProxy retransmission behavior

Gets rid of ObserveProxy retransmission which was only required
to facilitate excessive randomization in tests.

Gets rid of excessive randomization in tests. The new PortsTest
environment more closely emulates reality: Nodes operate
independently but there are some basic and trivially satisfiable
ordering guarantees.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController, which was only added to facilitate
ObserveProxy retransmission.

BUG=628492,635508
==========

[Ken Rockot(use gerrit already), 2016-08-08 18:29:33]

Description was changed from

==========
[mojo-edk] Revert ObserveProxy retransmission behavior

Gets rid of ObserveProxy retransmission which was only required
to facilitate excessive randomization in tests.

Gets rid of excessive randomization in tests. The new PortsTest
environment more closely emulates reality: Nodes operate
independently but there are some basic and trivially satisfiable
ordering guarantees.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController, which was only added to facilitate
ObserveProxy retransmission.

BUG=628492,635508
==========

to

==========
[mojo-edk] Revert ObserveProxy retransmission behavior

Gets rid of ObserveProxy retransmission which was only required
to facilitate excessive randomization in tests. In practice this
behavior can race with normal port closure and lead to busy
loops.

Gets rid of excessive randomization in tests. The new PortsTest
environment more closely emulates reality: Nodes operate
independently but there are some basic and trivially satisfiable
ordering guarantees.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController, which was only added to facilitate
ObserveProxy retransmission.

BUG=628492,635508
==========

[Ken Rockot(use gerrit already), 2016-08-08 19:25:16]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 19:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-08 19:29:16]

rockot@chromium.org changed reviewers:
+ yzshen@chromium.org

[Ken Rockot(use gerrit already), 2016-08-08 19:29:16]

Hi Yuzhu, could you please take a look? This is the CL we discussed last week.
Note that all changes to Node and NodeController are effectively just reverts of
recent changes. I have substantially changed the unit test code. I think it
should be easier to follow than it was, and the tests now more accurately
simulate a real EDK environment.

[Ken Rockot(use gerrit already), 2016-08-08 19:56:49]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 19:57:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:40:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 20:40:56]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-08-08 23:15:27]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:16:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-08 23:21:14]

lgtm

[Ken Rockot(use gerrit already), 2016-08-08 23:26:16]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-08 23:26:18]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:26:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 01:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:25:50]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Ken Rockot(use gerrit already), 2016-08-09 01:30:34]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:31:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 02:27:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-09 02:31:39]

Description was changed from

==========
[mojo-edk] Revert ObserveProxy retransmission behavior

Gets rid of ObserveProxy retransmission which was only required
to facilitate excessive randomization in tests. In practice this
behavior can race with normal port closure and lead to busy
loops.

Gets rid of excessive randomization in tests. The new PortsTest
environment more closely emulates reality: Nodes operate
independently but there are some basic and trivially satisfiable
ordering guarantees.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController, which was only added to facilitate
ObserveProxy retransmission.

BUG=628492,635508
==========

to

==========
[mojo-edk] Revert ObserveProxy retransmission behavior

Gets rid of ObserveProxy retransmission which was only required
to facilitate excessive randomization in tests. In practice this
behavior can race with normal port closure and lead to busy
loops.

Gets rid of excessive randomization in tests. The new PortsTest
environment more closely emulates reality: Nodes operate
independently but there are some basic and trivially satisfiable
ordering guarantees.

Gets rid of deferred AcceptIncomingMessages pumping in
NodeController, which was only added to facilitate
ObserveProxy retransmission.

BUG=628492,635508

Committed: https://crrev.com/36f85398960e7836d5325e1a58298209ced34f33
Cr-Commit-Position: refs/heads/master@{#410535}
==========

[commit-bot: I haz the power, 2016-08-09 02:31:40]

Patchset 5 (id:??) landed as
https://crrev.com/36f85398960e7836d5325e1a58298209ced34f33
Cr-Commit-Position: refs/heads/master@{#410535}