Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2236463004: Rename QuicSupportedVersions to QuicAllSupportedVersions. Add QuicCurrentSupportedVersions which re… (Closed)

Created:
4 years, 4 months ago by danzh1
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@129437595
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename QuicSupportedVersions to QuicAllSupportedVersions. Add QuicCurrentSupportedVersions which returns filtered supported versions based on flags. Not flag protected. Merge internal change: 129440821 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : update files not in net/ #

Patch Set 3 : update more files outside net/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -108 lines) Patch
M chrome/browser/io_thread_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/test/quic_test_server.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/ios/test/quic_test_server.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/proof_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_end_to_end_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_framer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_protocol.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/core/quic_protocol.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M net/quic/core/quic_protocol_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_received_packet_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/reliable_quic_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/chlo_extractor_test.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/quic_packet_printer_bin.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_bin.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_bin.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2231463003 Patch 20001

Dependent Patchsets:

Issue 2236513002 Patch 20001

Messages

Total messages: 13 (8 generated)
danzh1
4 years, 4 months ago (2016-08-10 13:51:10 UTC) #1
Ryan Hamilton
lgtm
4 years, 4 months ago (2016-08-10 14:24:06 UTC) #2
Ryan Hamilton
lgtm lgtm
4 years, 4 months ago (2016-08-10 14:24:07 UTC) #3
danzh1
On 2016/08/10 14:24:07, Ryan Hamilton wrote: > lgtm > > lgtm Didn't notice QuicSupportedVersions() is ...
4 years, 4 months ago (2016-08-10 20:40:29 UTC) #10
Ryan Hamilton
4 years, 4 months ago (2016-08-10 22:18:32 UTC) #13 
lgtm. thanks for catching this

Powered by Google App Engine
This is Rietveld 408576698