Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: net/quic/core/crypto/quic_crypto_client_config_test.cc

Issue 2236463004: Rename QuicSupportedVersions to QuicAllSupportedVersions. Add QuicCurrentSupportedVersions which re… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@129437595
Patch Set: update more files outside net/ Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/proof_test.cc ('k') | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/quic_crypto_client_config_test.cc
diff --git a/net/quic/core/crypto/quic_crypto_client_config_test.cc b/net/quic/core/crypto/quic_crypto_client_config_test.cc
index 9555dd195d7b4c84be10ed7d79a4fc5023e57cdc..36022ef20e7ada342f1a4512193e5ae709a9e52f 100644
--- a/net/quic/core/crypto/quic_crypto_client_config_test.cc
+++ b/net/quic/core/crypto/quic_crypto_client_config_test.cc
@@ -255,7 +255,7 @@ TEST(QuicCryptoClientConfigTest, FillClientHello) {
}
TEST(QuicCryptoClientConfigTest, ProcessServerDowngradeAttack) {
- QuicVersionVector supported_versions = QuicSupportedVersions();
+ QuicVersionVector supported_versions = AllSupportedVersions();
if (supported_versions.size() == 1) {
// No downgrade attack is possible if the client only supports one version.
return;
@@ -437,8 +437,8 @@ TEST(QuicCryptoClientConfigTest, ProcessReject) {
QuicCryptoClientConfig config(CryptoTestUtils::ProofVerifierForTesting());
EXPECT_EQ(QUIC_NO_ERROR,
config.ProcessRejection(rej, QuicWallTime::FromUNIXSeconds(0),
- QuicSupportedVersions().front(), "",
- &cached, &out_params, &error));
+ AllSupportedVersions().front(), "", &cached,
+ &out_params, &error));
EXPECT_FALSE(cached.has_server_designated_connection_id());
EXPECT_FALSE(cached.has_server_nonce());
}
@@ -459,8 +459,8 @@ TEST(QuicCryptoClientConfigTest, ProcessStatelessReject) {
QuicCryptoClientConfig config(CryptoTestUtils::ProofVerifierForTesting());
EXPECT_EQ(QUIC_NO_ERROR,
config.ProcessRejection(rej, QuicWallTime::FromUNIXSeconds(0),
- QuicSupportedVersions().front(), "",
- &cached, &out_params, &error));
+ AllSupportedVersions().front(), "", &cached,
+ &out_params, &error));
EXPECT_TRUE(cached.has_server_designated_connection_id());
EXPECT_EQ(kConnectionId, cached.GetNextServerDesignatedConnectionId());
EXPECT_EQ(server_nonce, cached.GetNextServerNonce());
@@ -479,8 +479,8 @@ TEST(QuicCryptoClientConfigTest, BadlyFormattedStatelessReject) {
QuicCryptoClientConfig config(CryptoTestUtils::ProofVerifierForTesting());
EXPECT_EQ(QUIC_CRYPTO_MESSAGE_PARAMETER_NOT_FOUND,
config.ProcessRejection(rej, QuicWallTime::FromUNIXSeconds(0),
- QuicSupportedVersions().front(), "",
- &cached, &out_params, &error));
+ AllSupportedVersions().front(), "", &cached,
+ &out_params, &error));
EXPECT_FALSE(cached.has_server_designated_connection_id());
EXPECT_EQ("Missing kRCID", error);
}
@@ -491,7 +491,7 @@ TEST(QuicCryptoClientConfigTest, ServerNonceinSHLO) {
msg.set_tag(kSHLO);
// Choose the latest version.
QuicVersionVector supported_versions;
- QuicVersion version = QuicSupportedVersions().front();
+ QuicVersion version = AllSupportedVersions().front();
supported_versions.push_back(version);
QuicTagVector versions;
versions.push_back(QuicVersionToQuicTag(version));
« no previous file with comments | « net/quic/core/crypto/proof_test.cc ('k') | net/quic/core/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698