src/heap/heap.cc - Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Introduce appropriate Type::Hole Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 46f114f11d8869c7e262fda444ff7c9e6793a8f1..ea8464bdc540d88d632ae04ac6132fc48a5ed858 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -2629,8 +2629,8 @@ void Heap::CreateInitialObjects() {

// Initialize the_hole_value.

Oddball::Initialize(isolate(), factory->the_hole_value(), "hole",

- handle(Smi::FromInt(-1), isolate()), "undefined",

- Oddball::kTheHole);

+ factory->NewHeapNumber(bit_cast<double>(kHoleNanInt64)),

Michael Starzinger 2016/08/10 13:59:37 nit: Please pretenure this heap-number to avoid ol

Benedikt Meurer 2016/08/10 14:01:00 Done.

+ "undefined", Oddball::kTheHole);

// Initialize the true_value.

Oddball::Initialize(isolate(), factory->true_value(), "true",

« no previous file with comments | « src/compiler/verifier.cc ('k') | src/types.h » ('j') | no next file with comments »