extensions: Use stl utilities from the base namespace

extensions: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
Committed: https://crrev.com/504e50206c42f42d17e3e67dd1d96667c6f2d885
Cr-Commit-Position: refs/heads/master@{#411627}

[Sami, 2016-08-10 10:29:44]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 10:30:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 12:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 12:05:53]

Dry run: This issue passed the CQ dry run.

[Sami, 2016-08-10 16:15:26]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:15:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-08-10 17:05:51]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 17:06:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-08-10 17:06:15]

Description was changed from

==========
extensions: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

to

==========
extensions: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

[Sami, 2016-08-10 17:06:15]

skyostil@chromium.org changed reviewers:
+ finnur@chromium.org

[Sami, 2016-08-10 17:06:28]

PTAL.

[commit-bot: I haz the power, 2016-08-10 17:54:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:54:48]

Dry run: This issue passed the CQ dry run.

[Finnur, 2016-08-11 10:19:47]

LGTM, module below.

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/api/...
File extensions/browser/api/declarative_webrequest/webrequest_condition.cc
(right):

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/api/...
extensions/browser/api/declarative_webrequest/webrequest_condition.cc:110: }
For a long time, we've asked people to not add braces to single line if-blocks
in extensions code, when only the conditional is multi-line.

So, I don't see adding braces as a positive here.

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/app_...
File extensions/browser/app_window/app_window_geometry_cache.cc (right):

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/app_...
extensions/browser/app_window/app_window_geometry_cache.cc:61: }
ditto here.

[Sami, 2016-08-12 10:56:39]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 10:57:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 11:51:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 11:51:14]

Dry run: This issue passed the CQ dry run.

[Sami, 2016-08-12 12:25:03]

Thanks.

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/api/...
File extensions/browser/api/declarative_webrequest/webrequest_condition.cc
(right):

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/api/...
extensions/browser/api/declarative_webrequest/webrequest_condition.cc:110: }
On 2016/08/11 10:19:47, Finnur wrote:
> For a long time, we've asked people to not add braces to single line if-blocks
> in extensions code, when only the conditional is multi-line.
> 
> So, I don't see adding braces as a positive here. 

Oh, I thought it was an oversight. Reverted to the previous style.

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/app_...
File extensions/browser/app_window/app_window_geometry_cache.cc (right):

https://codereview.chromium.org/2236443003/diff/40001/extensions/browser/app_...
extensions/browser/app_window/app_window_geometry_cache.cc:61: }
On 2016/08/11 10:19:47, Finnur wrote:
> ditto here.

Done.

[Sami, 2016-08-12 12:25:50]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-08-12 12:25:51]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/2236443003/#ps80001
(title: "Don't add braces")

[commit-bot: I haz the power, 2016-08-12 12:26:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 13:04:15]

Description was changed from

==========
extensions: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

to

==========
extensions: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

[commit-bot: I haz the power, 2016-08-12 13:04:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-12 13:07:48]

Description was changed from

==========
extensions: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301
==========

to

==========
extensions: Use stl utilities from the base namespace

The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.

No functional changes.

BUG=636301

Committed: https://crrev.com/504e50206c42f42d17e3e67dd1d96667c6f2d885
Cr-Commit-Position: refs/heads/master@{#411627}
==========

[commit-bot: I haz the power, 2016-08-12 13:07:49]

Patchset 5 (id:??) landed as
https://crrev.com/504e50206c42f42d17e3e67dd1d96667c6f2d885
Cr-Commit-Position: refs/heads/master@{#411627}