Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: extensions/common/features/base_feature_provider_unittest.cc

Issue 2236443003: extensions: Use stl utilities from the base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't add braces Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_set.cc ('k') | extensions/common/features/simple_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/base_feature_provider_unittest.cc
diff --git a/extensions/common/features/base_feature_provider_unittest.cc b/extensions/common/features/base_feature_provider_unittest.cc
index 52a8f796dae447e613dabdb4167818c4619eeac7..599a6a6d27b0cd86dd4b245904e32ef9d4c2d055 100644
--- a/extensions/common/features/base_feature_provider_unittest.cc
+++ b/extensions/common/features/base_feature_provider_unittest.cc
@@ -30,12 +30,13 @@ TEST(BaseFeatureProviderTest, ManifestFeatureTypes) {
const std::vector<Manifest::Type>& extension_types =
feature->extension_types();
EXPECT_EQ(6u, extension_types.size());
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_EXTENSION));
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_LEGACY_PACKAGED_APP));
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_PLATFORM_APP));
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_HOSTED_APP));
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_THEME));
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_SHARED_MODULE));
+ EXPECT_EQ(1, base::STLCount(extension_types, Manifest::TYPE_EXTENSION));
+ EXPECT_EQ(
+ 1, base::STLCount(extension_types, Manifest::TYPE_LEGACY_PACKAGED_APP));
+ EXPECT_EQ(1, base::STLCount(extension_types, Manifest::TYPE_PLATFORM_APP));
+ EXPECT_EQ(1, base::STLCount(extension_types, Manifest::TYPE_HOSTED_APP));
+ EXPECT_EQ(1, base::STLCount(extension_types, Manifest::TYPE_THEME));
+ EXPECT_EQ(1, base::STLCount(extension_types, Manifest::TYPE_SHARED_MODULE));
}
// Tests that real manifest features have the correct availability for an
@@ -87,9 +88,10 @@ TEST(BaseFeatureProviderTest, PermissionFeatureTypes) {
const std::vector<Manifest::Type>& extension_types =
feature->extension_types();
EXPECT_EQ(3u, extension_types.size());
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_EXTENSION));
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_LEGACY_PACKAGED_APP));
- EXPECT_EQ(1, STLCount(extension_types, Manifest::TYPE_PLATFORM_APP));
+ EXPECT_EQ(1, base::STLCount(extension_types, Manifest::TYPE_EXTENSION));
+ EXPECT_EQ(
+ 1, base::STLCount(extension_types, Manifest::TYPE_LEGACY_PACKAGED_APP));
+ EXPECT_EQ(1, base::STLCount(extension_types, Manifest::TYPE_PLATFORM_APP));
}
// Tests that real permission features have the correct availability for an app.
« no previous file with comments | « extensions/common/extension_set.cc ('k') | extensions/common/features/simple_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698