Remove PasswordAutofillAgent::TextFieldDidEndEditing

Remove PasswordAutofillAgent::TextFieldDidEndEditing

PasswordAutofillAgent::TextFieldDidEndEditing provided special handling for
situations when automatic filling was blocked (Incognito, PSL-matched
credentials, etc.): in those cases, when the user filled the username to match
some of the fillable credentials, that credential was filled even though the
user did not select a fill suggestion.

It is no longer clear what was the motivation for this behaviour. The code has
been like this before it was ported from WebKit in 2010. It seems unnecessary,
a little unexpected, and leads to a bug when a page can trigger autofill of
credentials with empty usernames in cases where they should not be autofilled
(e.g., Incognito).

Therefore, this CL removes PasswordAutofillAgent::TextFieldDidEndEditing and
the associated functionality: credentials are now only filled when the user
selects a suggestion (or when the credentials are fit for automatic filling).

R=dvadym@chromium.org
BUG=636461
Committed: https://crrev.com/36c4ef576660b52e1a5750b313ae3031ea1b4e81
Cr-Commit-Position: refs/heads/master@{#411335}

[vabr (Chromium), 2016-08-11 14:02:49]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 14:03:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-11 14:54:39]

Hi Vadym, PTAL.

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-08-11 14:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 14:55:11]

Dry run: This issue passed the CQ dry run.

[dvadym, 2016-08-11 14:56:24]

LGTM, thanks for fixing this

[vabr (Chromium), 2016-08-11 15:18:37]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-08-11 15:19:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 15:23:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-11 15:26:24]

Description was changed from

==========
Remove PasswordAutofillAgent::TextFieldDidEndEditing

PasswordAutofillAgent::TextFieldDidEndEditing provided special handling for
situations when automatic filling was blocked (Incognito, PSL-matched
credentials, etc.): in those cases, when the user filled the username to match
some of the fillable credentials, that credential was filled even though the
user did not select a fill suggestion.

It is no longer clear what was the motivation for this behaviour. The code has
been like this before it was ported from WebKit in 2010. It seems unnecessary,
a little unexpected, and leads to a bug when a page can trigger autofill of
credentials with empty usernames in cases where they should not be autofilled
(e.g., Incognito).

Therefore, this CL removes PasswordAutofillAgent::TextFieldDidEndEditing and
the associated functionality: credentials are now only filled when the user
selects a suggestion (or when the credentials are fit for automatic filling).

R=dvadym@chromium.org
BUG=636461
==========

to

==========
Remove PasswordAutofillAgent::TextFieldDidEndEditing

PasswordAutofillAgent::TextFieldDidEndEditing provided special handling for
situations when automatic filling was blocked (Incognito, PSL-matched
credentials, etc.): in those cases, when the user filled the username to match
some of the fillable credentials, that credential was filled even though the
user did not select a fill suggestion.

It is no longer clear what was the motivation for this behaviour. The code has
been like this before it was ported from WebKit in 2010. It seems unnecessary,
a little unexpected, and leads to a bug when a page can trigger autofill of
credentials with empty usernames in cases where they should not be autofilled
(e.g., Incognito).

Therefore, this CL removes PasswordAutofillAgent::TextFieldDidEndEditing and
the associated functionality: credentials are now only filled when the user
selects a suggestion (or when the credentials are fit for automatic filling).

R=dvadym@chromium.org
BUG=636461

Committed: https://crrev.com/36c4ef576660b52e1a5750b313ae3031ea1b4e81
Cr-Commit-Position: refs/heads/master@{#411335}
==========

[commit-bot: I haz the power, 2016-08-11 15:26:26]

Patchset 2 (id:??) landed as
https://crrev.com/36c4ef576660b52e1a5750b313ae3031ea1b4e81
Cr-Commit-Position: refs/heads/master@{#411335}