Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 2236413002: Remove PasswordAutofillAgent::TextFieldDidEndEditing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improved one test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/autofill_agent.h" 5 #include "components/autofill/content/renderer/autofill_agent.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <tuple> 9 #include <tuple>
10 10
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 // Show full suggestions when clicking on an already-focused form field. On 324 // Show full suggestions when clicking on an already-focused form field. On
325 // the initial click (not focused yet), only show password suggestions. 325 // the initial click (not focused yet), only show password suggestions.
326 options.show_full_suggestion_list = 326 options.show_full_suggestion_list =
327 options.show_full_suggestion_list || was_focused; 327 options.show_full_suggestion_list || was_focused;
328 options.show_password_suggestions_only = !was_focused; 328 options.show_password_suggestions_only = !was_focused;
329 } 329 }
330 ShowSuggestions(element, options); 330 ShowSuggestions(element, options);
331 } 331 }
332 332
333 void AutofillAgent::textFieldDidEndEditing(const WebInputElement& element) { 333 void AutofillAgent::textFieldDidEndEditing(const WebInputElement& element) {
334 password_autofill_agent_->TextFieldDidEndEditing(element);
335 GetAutofillDriver()->DidEndTextFieldEditing(); 334 GetAutofillDriver()->DidEndTextFieldEditing();
336 } 335 }
337 336
338 void AutofillAgent::textFieldDidChange(const WebFormControlElement& element) { 337 void AutofillAgent::textFieldDidChange(const WebFormControlElement& element) {
339 DCHECK(toWebInputElement(&element) || form_util::IsTextAreaElement(element)); 338 DCHECK(toWebInputElement(&element) || form_util::IsTextAreaElement(element));
340 339
341 if (ignore_text_changes_) 340 if (ignore_text_changes_)
342 return; 341 return;
343 342
344 // Disregard text changes that aren't caused by user gestures or pastes. Note 343 // Disregard text changes that aren't caused by user gestures or pastes. Note
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 void AutofillAgent::LegacyAutofillAgent::OnDestruct() { 807 void AutofillAgent::LegacyAutofillAgent::OnDestruct() {
809 // No-op. Don't delete |this|. 808 // No-op. Don't delete |this|.
810 } 809 }
811 810
812 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() { 811 void AutofillAgent::LegacyAutofillAgent::FocusChangeComplete() {
813 if (agent_) 812 if (agent_)
814 agent_->FocusChangeComplete(); 813 agent_->FocusChangeComplete();
815 } 814 }
816 815
817 } // namespace autofill 816 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698