third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2236403004: Handling new frames and frame navigations with find-in-page during a find session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2236403004: Handling new frames and frame navigations with find-in-page during a find session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and updated comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/find_bar/find_bar_controller.cc ('K') | « third_party/WebKit/Source/web/TextFinder.cpp ('k') | third_party/WebKit/public/web/WebFindOptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 35f082f93ee99b928d653887af87700bbf045d59..0711e392b1cba2555890275d249f94c221d88b5b 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1974,7 +1974,7 @@ void WebLocalFrameImpl::didCallIsSearchProviderInstalled()

void WebLocalFrameImpl::requestFind(int identifier, const WebString& searchText, const WebFindOptions& options)

{

// Send "no results" if this frame has no visible content.

- if (!hasVisibleContent()) {

+ if (!hasVisibleContent() && !options.force) {

client()->reportFindInPageMatchCount(identifier, 0 /* count */, true /* finalUpdate */);

return;

}