chrome/browser/ui/find_bar/find_bar_controller.cc - Issue 2236403004: Handling new frames and frame navigations with find-in-page during a find session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_bar_controller.cc

Issue 2236403004: Handling new frames and frame navigations with find-in-page during a find session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and updated comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/find_bar/find_bar_controller.cc

diff --git a/chrome/browser/ui/find_bar/find_bar_controller.cc b/chrome/browser/ui/find_bar/find_bar_controller.cc

index f30cf920bc94356e5d95cbec12a3ae878cd53c22..df1001e1d2266c460a3e09e0927bd158dd05e739 100644

--- a/chrome/browser/ui/find_bar/find_bar_controller.cc

+++ b/chrome/browser/ui/find_bar/find_bar_controller.cc

@@ -159,7 +159,7 @@ void FindBarController::Observe(int type,

ui::PageTransition transition_type =

commit_details->entry->GetTransitionType();

// Hide the find bar on reload or navigation.

- if (find_bar_->IsFindBarVisible() &&

+ if (find_bar_->IsFindBarVisible() && commit_details->is_main_frame &&

Peter Kasting 2016/09/23 00:12:34 It seems a little surprising that we'd need this.

(ui::PageTransitionCoreTypeIs(transition_type,

ui::PAGE_TRANSITION_RELOAD) ||

commit_details->is_navigation_to_different_page()))

« no previous file with comments | « no previous file | content/browser/find_request_manager.h » ('j') | no next file with comments »