Issue 22364004: Revert 215836 "Ensure that renderer-initiated pending entries ca..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22364004: Revert 215836 "Ensure that renderer-initiated pending entries ca..." (Closed)

Created:
7 years, 4 months ago by Charlie Reis

Modified:
7 years, 4 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 215836 "Ensure that renderer-initiated pending entries ca..." Caused flakiness on Linux ASAN PlatformAppBrowserTest.DisallowNavigation. > Ensure that renderer-initiated pending entries can be replaced when a new > navigation is started. > > We don't replace browser-initiated pending entries in didStartProvisionalLoad > because either (1) they were just created for this navigation and are already > correct, (2) they're for a different SiteInstance and won't be used upon > commit, or (3) they're same-site (see below). > > Note that pending entries for same-site browser-initiated navigations can be > incorrectly used for renderer-initiated navigations that interrupt them, but > that's a long standing bug that we can address separately. > > BUG=266922 > TEST=See bug for repro steps. > > Review URL: https://chromiumcodereview.appspot.com/21913003 TBR=creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215904

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -66 lines)			Patch
M	trunk/src/content/browser/renderer_host/test_render_view_host.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	trunk/src/content/browser/web_contents/navigation_controller_impl_unittest.cc	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	trunk/src/content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+16 lines, -22 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r215904.

Expand Messages | Collapse Messages