Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: trunk/src/content/browser/renderer_host/test_render_view_host.cc

Issue 22364004: Revert 215836 "Ensure that renderer-initiated pending entries ca..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/browser/web_contents/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/browser/renderer_host/test_render_view_host.cc
===================================================================
--- trunk/src/content/browser/renderer_host/test_render_view_host.cc (revision 215902)
+++ trunk/src/content/browser/renderer_host/test_render_view_host.cc (working copy)
@@ -311,12 +311,8 @@
void TestRenderViewHost::SendNavigateWithTransitionAndResponseCode(
int page_id, const GURL& url, PageTransition transition,
int response_code) {
- // DidStartProvisionalLoad may delete the pending entry that holds |url|,
- // so we keep a copy of it to use in SendNavigateWithParameters.
- GURL url_copy(url);
- OnDidStartProvisionalLoadForFrame(kFrameId, -1, true, url_copy);
- SendNavigateWithParameters(page_id, url_copy, transition, url_copy,
- response_code, 0);
+ OnDidStartProvisionalLoadForFrame(kFrameId, -1, true, url);
+ SendNavigateWithParameters(page_id, url, transition, url, response_code, 0);
}
void TestRenderViewHost::SendNavigateWithParameters(
« no previous file with comments | « no previous file | trunk/src/content/browser/web_contents/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698