Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2236313004: Revert of Fail builds when lint warnings are generated. (Closed)

Created:
4 years, 4 months ago by caseq
Modified:
4 years, 4 months ago
Reviewers:
estevenson, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fail builds when lint warnings are generated. (patchset #3 id:40001 of https://codereview.chromium.org/2240573004/ ) Reason for revert: Broke Android Arm64 builder. Original issue's description: > Fail builds when lint warnings are generated. > > Suppress all existing lint warnings so that builds will fail when new > warnings are generated. New lint warnings that are generated in files > that are ignored in suppressions.xml will not be caught. However, now > we can remove lint warnings on a file by file basis instead of having to > fix all lint warnings before making lint break builds. > > BUG=607761 > > Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe > Committed: https://crrev.com/9a52a7e12ad50f6f85e88c6a5636ce6e0a405dce > Cr-Original-Commit-Position: refs/heads/master@{#411692} > Cr-Commit-Position: refs/heads/master@{#411748} TBR=agrieve@chromium.org,estevenson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607761 Committed: https://crrev.com/0b8904601897107f297027eecbb7572bb7bf902d Cr-Commit-Position: refs/heads/master@{#411764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -197 lines) Patch
M build/android/gyp/lint.py View 1 chunk +1 line, -4 lines 0 comments Download
M build/android/lint/suppressions.xml View 1 chunk +59 lines, -192 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
Created Revert of Fail builds when lint warnings are generated.
4 years, 4 months ago (2016-08-12 21:03:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236313004/1
4 years, 4 months ago (2016-08-12 21:04:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 21:05:10 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0b8904601897107f297027eecbb7572bb7bf902d Cr-Commit-Position: refs/heads/master@{#411764}
4 years, 4 months ago (2016-08-12 21:06:44 UTC) #6
agrieve
4 years, 4 months ago (2016-08-13 01:46:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2241973002/ by agrieve@chromium.org.

The reason for reverting is: If this fails again, please revert changes that
introduce
new warnings rather than this patch..

Powered by Google App Engine
This is Rietveld 408576698