Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: build/android/gyp/lint.py

Issue 2236313004: Revert of Fail builds when lint warnings are generated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/lint/suppressions.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Runs Android's lint tool.""" 7 """Runs Android's lint tool."""
8 8
9 9
10 import argparse 10 import argparse
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 324
325 for gyp_list in args.resource_sources: 325 for gyp_list in args.resource_sources:
326 resource_sources += build_utils.ParseGypList(gyp_list) 326 resource_sources += build_utils.ParseGypList(gyp_list)
327 327
328 for resource_source in resource_sources: 328 for resource_source in resource_sources:
329 if os.path.isdir(resource_source): 329 if os.path.isdir(resource_source):
330 input_paths.extend(build_utils.FindInDirectory(resource_source, '*')) 330 input_paths.extend(build_utils.FindInDirectory(resource_source, '*'))
331 else: 331 else:
332 input_paths.append(resource_source) 332 input_paths.append(resource_source)
333 333
334 input_strings = [ 334 input_strings = []
335 args.can_fail_build,
336 args.silent,
337 ]
338 if args.android_sdk_version: 335 if args.android_sdk_version:
339 input_strings.append(args.android_sdk_version) 336 input_strings.append(args.android_sdk_version)
340 if args.processed_config_path: 337 if args.processed_config_path:
341 input_strings.append(args.processed_config_path) 338 input_strings.append(args.processed_config_path)
342 339
343 output_paths = [ args.result_path ] 340 output_paths = [ args.result_path ]
344 341
345 build_utils.CallAndWriteDepfileIfStale( 342 build_utils.CallAndWriteDepfileIfStale(
346 lambda: _OnStaleMd5(args.lint_path, 343 lambda: _OnStaleMd5(args.lint_path,
347 args.config_path, 344 args.config_path,
348 args.processed_config_path, 345 args.processed_config_path,
349 args.manifest_path, args.result_path, 346 args.manifest_path, args.result_path,
350 args.product_dir, sources, 347 args.product_dir, sources,
351 args.jar_path, 348 args.jar_path,
352 args.cache_dir, 349 args.cache_dir,
353 args.android_sdk_version, 350 args.android_sdk_version,
354 resource_sources, 351 resource_sources,
355 classpath=classpath, 352 classpath=classpath,
356 can_fail_build=args.can_fail_build, 353 can_fail_build=args.can_fail_build,
357 silent=args.silent), 354 silent=args.silent),
358 args, 355 args,
359 input_paths=input_paths, 356 input_paths=input_paths,
360 input_strings=input_strings, 357 input_strings=input_strings,
361 output_paths=output_paths, 358 output_paths=output_paths,
362 depfile_deps=classpath) 359 depfile_deps=classpath)
363 360
364 361
365 if __name__ == '__main__': 362 if __name__ == '__main__':
366 sys.exit(main()) 363 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | build/android/lint/suppressions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698