src/arm/simulator-arm.cc - Issue 223623003: Fix fixed-point vcvt_f64_s32 immediate value encoding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/simulator-arm.cc

Issue 223623003: Fix fixed-point vcvt_f64_s32 immediate value encoding (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Reorder bits for clarity Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/simulator-arm.cc

diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc

index 8f7c1e8bb2b740e7884c6ae52c6b867681c9e125..103b570e248c7c8a51f5857177fa6bc7e73e5f9b 100644

--- a/src/arm/simulator-arm.cc

+++ b/src/arm/simulator-arm.cc

@@ -2936,7 +2936,7 @@ void Simulator::DecodeTypeVFP(Instruction* instr) {

} else if ((instr->Opc2Value() == 0xA) && (instr->Opc3Value() == 0x3) &&

(instr->Bit(8) == 1)) {

// vcvt.f64.s32 Dd, Dd, #<fbits>

- int fraction_bits = 32 - ((instr->Bit(5) << 4) | instr->Bits(3, 0));

+ int fraction_bits = 32 - ((instr->Bits(3, 0) << 1) | instr->Bit(5));

int fixed_value = get_sinteger_from_s_register(vd * 2);

double divide = 1 << fraction_bits;

set_d_register_from_double(vd, fixed_value / divide);

« no previous file with comments | « src/arm/disasm-arm.cc ('k') | test/cctest/test-assembler-arm.cc » ('j') | no next file with comments »