Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2236153002: X87: [turbofan] Remove the FloatXXSubPreserveNan operators. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Remove the FloatXXSubPreserveNan operators. port f8938e50964e7b83818a0fff7fc0f2b065f8bf49 (r38437) original commit message: This CL changes the semantics of FloatXXSub to match the semantics of the semantics of FloatXXSubPreserveNan. Therefore there is no need anymore for the FloatXXSubPreserveNan operators. The optimizations in VisitFloatXXSub which are removed in this CL have already been moved to machine-operator-reducer.cc in https://codereview.chromium.org/2226663002 BUG= Committed: https://crrev.com/4a1ae109528f52a9e8d002321c448dcd5366763a Cr-Commit-Position: refs/heads/master@{#38571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-11 03:26:44 UTC) #2
ahaas
lgtm
4 years, 4 months ago (2016-08-11 06:39:21 UTC) #3
Weiliang
lgtm
4 years, 4 months ago (2016-08-11 06:43:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236153002/1
4 years, 4 months ago (2016-08-11 08:35:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 08:56:02 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 08:56:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a1ae109528f52a9e8d002321c448dcd5366763a
Cr-Commit-Position: refs/heads/master@{#38571}

Powered by Google App Engine
This is Rietveld 408576698