Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2236033003: Make downloaded WebAPK world readable (Closed)

Created:
4 years, 4 months ago by pkotwicz
Modified:
4 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews, dominickn+watch_chromium.org, Xi Han
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make downloaded WebAPK world readable Make downloaded WebAPK world readable. This is necessary in order to install WebAPKs when the user has enabled "installation from unknown sources". BUG=635373 Committed: https://crrev.com/f5345736320415ba85e7543bd38f4e8aa897cdf0 Cr-Commit-Position: refs/heads/master@{#411791}

Patch Set 1 : Merge branch 'webapk_builder_impl2_thread' into webapk_thread_install #

Total comments: 1

Patch Set 2 : Merge branch 'master' into webapk_builder_impl2_directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer.h View 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer.cc View 3 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pkotwicz
Yaron can you please take a look? I think that this is the last CL ...
4 years, 4 months ago (2016-08-10 22:22:45 UTC) #3
Yaron
lgtm
4 years, 4 months ago (2016-08-10 23:13:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236033003/80001
4 years, 4 months ago (2016-08-12 21:18:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 4 months ago (2016-08-12 21:59:02 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 22:00:39 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5345736320415ba85e7543bd38f4e8aa897cdf0
Cr-Commit-Position: refs/heads/master@{#411791}

Powered by Google App Engine
This is Rietveld 408576698