chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java - Issue 2236033003: Make downloaded WebAPK world readable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

Issue 2236033003: Make downloaded WebAPK world readable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_builder_impl2_directory Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

index fd0629e9ad4b94a5327049be5bd2eb96efba4fad..e41e461cd3ea400b3a8b53d983d7944c5d7b64cd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

@@ -37,9 +37,6 @@ public class WebApkInstaller {

"WebAPK install failed because installation from unknown sources is disabled.");

return false;

}

- if (!new File(filePath).exists()) {

- return false;

- }

Intent intent = new Intent(Intent.ACTION_VIEW);

Uri fileUri = Uri.fromFile(new File(filePath));

intent.setDataAndType(fileUri, "application/vnd.android.package-archive");

« no previous file with comments | « no previous file | chrome/browser/android/webapk/webapk_installer.h » ('j') | no next file with comments »