Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2235993002: Move mojo/public/c/environment/tests to mojo/public/c/tests/environment. (Closed)

Created:
4 years, 4 months ago by viettrungluu
Modified:
4 years, 4 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move mojo/public/c/environment/tests to mojo/public/c/tests/environment. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/03a3949b7da7f0f56ab05a2aed4bfe147a072cfe

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -195 lines) Patch
M mojo/environment/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/async_wait_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/BUILD.gn View 1 1 chunk +15 lines, -0 lines 0 comments Download
D mojo/public/c/environment/tests/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/public/c/environment/tests/async_waiter_perftest_helpers.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/public/c/environment/tests/async_waiter_perftest_helpers.cc View 1 chunk +0 lines, -136 lines 0 comments Download
A + mojo/public/c/tests/environment/async_waiter_perftest_helpers.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/c/tests/environment/async_waiter_perftest_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/tests/run_loop_async_wait_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 4 months ago (2016-08-10 20:20:00 UTC) #1
jamesr
lgtm
4 years, 4 months ago (2016-08-10 20:25:33 UTC) #2
viettrungluu
4 years, 4 months ago (2016-08-10 20:33:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
03a3949b7da7f0f56ab05a2aed4bfe147a072cfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698