Make Document's 'info' property readonly

fpdfsdk/javascript/Document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/javascript/Document.h"
 
 #include <vector>
 
@@ skipping 731 matching lines @@
 
 FX_BOOL Document::author(IJS_Context* cc,
                          CJS_PropValue& vp,
                          CFX_WideString& sError) {
   return getPropertyInternal(cc, vp, "Author", sError);
 }
 
 FX_BOOL Document::info(IJS_Context* cc,
                        CJS_PropValue& vp,
                        CFX_WideString& sError) {
+  if (vp.IsSetting()) {
+    CJS_Context* pContext = static_cast<CJS_Context*>(cc);
+    sError = JSGetStringFromID(pContext, IDS_STRING_JSREADONLY);
+    return FALSE;
+  }
+
   CPDF_Dictionary* pDictionary = m_pDocument->GetPDFDocument()->GetInfo();
   if (!pDictionary)
     return FALSE;
 
   CFX_WideString cwAuthor = pDictionary->GetUnicodeTextBy("Author");
   CFX_WideString cwTitle = pDictionary->GetUnicodeTextBy("Title");
   CFX_WideString cwSubject = pDictionary->GetUnicodeTextBy("Subject");
   CFX_WideString cwKeywords = pDictionary->GetUnicodeTextBy("Keywords");
   CFX_WideString cwCreator = pDictionary->GetUnicodeTextBy("Creator");
   CFX_WideString cwProducer = pDictionary->GetUnicodeTextBy("Producer");
   CFX_WideString cwCreationDate = pDictionary->GetUnicodeTextBy("CreationDate");
   CFX_WideString cwModDate = pDictionary->GetUnicodeTextBy("ModDate");
   CFX_WideString cwTrapped = pDictionary->GetUnicodeTextBy("Trapped");
 
+  CJS_Context* pContext = (CJS_Context*)cc;
+  CJS_Runtime* pRuntime = pContext->GetJSRuntime();
+  v8::Local<v8::Object> pObj =
+      FXJS_NewFxDynamicObj(pRuntime->GetIsolate(), pRuntime, -1);
+
   v8::Isolate* isolate = GetIsolate(cc);
-  if (vp.IsGetting()) {
-    CJS_Context* pContext = (CJS_Context*)cc;
-    CJS_Runtime* pRuntime = pContext->GetJSRuntime();
-    v8::Local<v8::Object> pObj =
-        FXJS_NewFxDynamicObj(pRuntime->GetIsolate(), pRuntime, -1);
-    FXJS_PutObjectString(isolate, pObj, L"Author", cwAuthor);
-    FXJS_PutObjectString(isolate, pObj, L"Title", cwTitle);
-    FXJS_PutObjectString(isolate, pObj, L"Subject", cwSubject);
-    FXJS_PutObjectString(isolate, pObj, L"Keywords", cwKeywords);
-    FXJS_PutObjectString(isolate, pObj, L"Creator", cwCreator);
-    FXJS_PutObjectString(isolate, pObj, L"Producer", cwProducer);
-    FXJS_PutObjectString(isolate, pObj, L"CreationDate", cwCreationDate);
-    FXJS_PutObjectString(isolate, pObj, L"ModDate", cwModDate);
-    FXJS_PutObjectString(isolate, pObj, L"Trapped", cwTrapped);
+  FXJS_PutObjectString(isolate, pObj, L"Author", cwAuthor);
+  FXJS_PutObjectString(isolate, pObj, L"Title", cwTitle);
+  FXJS_PutObjectString(isolate, pObj, L"Subject", cwSubject);
+  FXJS_PutObjectString(isolate, pObj, L"Keywords", cwKeywords);
+  FXJS_PutObjectString(isolate, pObj, L"Creator", cwCreator);
+  FXJS_PutObjectString(isolate, pObj, L"Producer", cwProducer);
+  FXJS_PutObjectString(isolate, pObj, L"CreationDate", cwCreationDate);
+  FXJS_PutObjectString(isolate, pObj, L"ModDate", cwModDate);
+  FXJS_PutObjectString(isolate, pObj, L"Trapped", cwTrapped);
 
-    // It's to be compatible to non-standard info dictionary.
-    for (const auto& it : *pDictionary) {
-      const CFX_ByteString& bsKey = it.first;
-      CPDF_Object* pValueObj = it.second;
-      CFX_WideString wsKey = CFX_WideString::FromUTF8(bsKey.AsStringC());
-      if (pValueObj->IsString() || pValueObj->IsName()) {
-        FXJS_PutObjectString(isolate, pObj, wsKey, pValueObj->GetUnicodeText());
-      } else if (pValueObj->IsNumber()) {
-        FXJS_PutObjectNumber(isolate, pObj, wsKey,
-                             (float)pValueObj->GetNumber());
-      } else if (pValueObj->IsBoolean()) {
-        FXJS_PutObjectBoolean(isolate, pObj, wsKey, !!pValueObj->GetInteger());
-      }
+  // It's to be compatible to non-standard info dictionary.
+  for (const auto& it : *pDictionary) {
+    const CFX_ByteString& bsKey = it.first;
+    CPDF_Object* pValueObj = it.second;
+    CFX_WideString wsKey = CFX_WideString::FromUTF8(bsKey.AsStringC());
+    if (pValueObj->IsString() || pValueObj->IsName()) {
+      FXJS_PutObjectString(isolate, pObj, wsKey, pValueObj->GetUnicodeText());
+    } else if (pValueObj->IsNumber()) {
+      FXJS_PutObjectNumber(isolate, pObj, wsKey, (float)pValueObj->GetNumber());
+    } else if (pValueObj->IsBoolean()) {
+      FXJS_PutObjectBoolean(isolate, pObj, wsKey, !!pValueObj->GetInteger());
     }
-    vp << pObj;
   }
+  vp << pObj;
   return TRUE;
 }
 
 FX_BOOL Document::getPropertyInternal(IJS_Context* cc,
                                       CJS_PropValue& vp,
                                       const CFX_ByteString& propName,
                                       CFX_WideString& sError) {
   CPDF_Dictionary* pDictionary = m_pDocument->GetPDFDocument()->GetInfo();
   if (!pDictionary)
     return FALSE;
@@ skipping 766 matching lines @@
     }
   }
 
   for (const auto& pData : DelayDataForFieldAndControlIndex)
     Field::DoDelay(m_pDocument, pData.get());
 }
 
 CJS_Document* Document::GetCJSDoc() const {
   return static_cast<CJS_Document*>(m_pJSObject);
 }