Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 2235883003: Make Document's 'info' property readonly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 3 weeks ago by tonikitoo
Modified:
9 months, 3 weeks ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make Document's 'info' property readonly As per the PDF specification in [1], page 103, the 'info' property of the Document object is readonly. [1] http://partners.adobe.com/public/developer/en/acrobat/sdk/5186AcroJS.pdf Committed: https://pdfium.googlesource.com/pdfium/+/ec2687680b0d033c3634e8dd0f8d8586c13494f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -30 lines) Patch
M fpdfsdk/javascript/Document.cpp View 2 chunks +33 lines, -29 lines 0 comments Download
M testing/resources/javascript/document_props_expected.txt View 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (4 generated)
tonikitoo
PTAL
9 months, 3 weeks ago (2016-08-10 18:22:17 UTC) #3
dsinclair
From reading the doc, it seems like it's Read-Only in Acrobat Reader but Read/Write in ...
9 months, 3 weeks ago (2016-08-10 18:38:54 UTC) #4
tonikitoo
On 2016/08/10 18:38:54, dsinclair wrote: > From reading the doc, it seems like it's Read-Only ...
9 months, 3 weeks ago (2016-08-10 18:48:14 UTC) #5
tonikitoo
On 2016/08/10 18:48:14, tonikitoo1 wrote: > On 2016/08/10 18:38:54, dsinclair wrote: > > From reading ...
9 months, 3 weeks ago (2016-08-10 18:50:39 UTC) #6
dsinclair
On 2016/08/10 18:48:14, tonikitoo1 wrote: > On 2016/08/10 18:38:54, dsinclair wrote: > > From reading ...
9 months, 3 weeks ago (2016-08-10 18:52:11 UTC) #7
tonikitoo
On 2016/08/10 18:52:11, dsinclair wrote: > On 2016/08/10 18:48:14, tonikitoo1 wrote: > > On 2016/08/10 ...
9 months, 3 weeks ago (2016-08-10 19:06:35 UTC) #8
dsinclair
On 2016/08/10 18:52:11, dsinclair wrote: > On 2016/08/10 18:48:14, tonikitoo1 wrote: > > On 2016/08/10 ...
9 months, 3 weeks ago (2016-08-10 19:06:47 UTC) #9
dsinclair
lgtm Discussed this with Tom, since we don't support writing it makes sense to make ...
9 months, 3 weeks ago (2016-08-10 19:09:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235883003/1
9 months, 3 weeks ago (2016-08-10 19:09:47 UTC) #12
commit-bot: I haz the power
9 months, 3 weeks ago (2016-08-10 19:29:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ec2687680b0d033c3634e8dd0f8d8586c134...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06