[system-health] Rename browse:media:facebook to browse:media:facebook_photos

[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

Finally, the patch fixes the SystemHealthStory metaclass logic.

BUG=636401
Committed: https://crrev.com/ec24992b4167ab4ca119601d5ca93522711a43d8
Cr-Commit-Position: refs/heads/master@{#411072}

[petrcermak, 2016-08-10 15:18:26]

Description was changed from

==========
[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

BUG=636401
==========

to

==========
[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

Finally, the patch fixes the SystemHealthStory metaclass logic.

BUG=636401
==========

[petrcermak, 2016-08-10 15:19:34]

petrcermak@chromium.org changed reviewers:
+ hpayer@chromium.org, nednguyen@google.com

[petrcermak, 2016-08-10 15:19:34]

PTAL.

Thanks,
Petr

[nednguyen, 2016-08-10 15:21:42]

lgtm

[petrcermak, 2016-08-10 15:25:31]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:25:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:29:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:29:38]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[petrcermak, 2016-08-10 15:32:19]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:32:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:37:45]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[petrcermak, 2016-08-10 16:10:53]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-08-10 16:11:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:40:23]

Description was changed from

==========
[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

Finally, the patch fixes the SystemHealthStory metaclass logic.

BUG=636401
==========

to

==========
[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

Finally, the patch fixes the SystemHealthStory metaclass logic.

BUG=636401
==========

[commit-bot: I haz the power, 2016-08-10 17:40:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-10 17:42:15]

Description was changed from

==========
[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

Finally, the patch fixes the SystemHealthStory metaclass logic.

BUG=636401
==========

to

==========
[system-health] Rename browse:media:facebook to browse:media:facebook_photos

As part of the renaming, the patch changes the name of the classes
defining the stories ("Facebook(Mobile|Desktop)Story" to
"FacebookPhotos(Mobile|Desktop)Story" to avoid the clash with
browse:social:facebook (see the bug below).

The patch also adds a corresponding loading story
(load:media:facebook_photos) and removes the initial navigation to
facebook.com/rihanna from browse:media:facebook_photos. As a result,
there will be 4 Facebook stories on each platform:

  load:social:facebook
  browse:social:facebook
  load:media:facebook_photos
  browse:media:facebook_photos

Finally, the patch fixes the SystemHealthStory metaclass logic.

BUG=636401

Committed: https://crrev.com/ec24992b4167ab4ca119601d5ca93522711a43d8
Cr-Commit-Position: refs/heads/master@{#411072}
==========

[commit-bot: I haz the power, 2016-08-10 17:42:16]

Patchset 1 (id:??) landed as
https://crrev.com/ec24992b4167ab4ca119601d5ca93522711a43d8
Cr-Commit-Position: refs/heads/master@{#411072}