tools/perf/page_sets/system_health/browsing_stories.py - Issue 2235803002: [system-health] Rename browse:media:facebook to browse:media:facebook_photos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2235803002: [system-health] Rename browse:media:facebook to browse:media:facebook_photos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/data/system_health_mobile_007.wpr.sha1 ('k') | tools/perf/page_sets/system_health/loading_stories.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/system_health/browsing_stories.py

diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py

index 25bf5b81f8f61a0a8bb5aed0029435f4420fe7b2..5ad8150b24308e947f0c244ff0db0a28768d3e73 100644

--- a/tools/perf/page_sets/system_health/browsing_stories.py

+++ b/tools/perf/page_sets/system_health/browsing_stories.py

@@ -280,8 +280,8 @@ class YouTubeDesktopStory(_MediaBrowsingStory):

ITEM_SELECTOR_INDEX = 3

-class FacebookMobileStory(_MediaBrowsingStory):

- NAME = 'browse:media:facebook'

+class FacebookPhotosMediaStory(_MediaBrowsingStory):

+ NAME = 'browse:media:facebook_photos'

URL = (

'https://m.facebook.com/rihanna/photos/a.207477806675.138795.10092511675/10153911739606676/?type=3&source=54&ref=page_internal')

ITEM_SELECTOR = '._57-r.touchable'

@@ -289,13 +289,9 @@ class FacebookMobileStory(_MediaBrowsingStory):

IS_SINGLE_PAGE_APP = True

ITEM_SELECTOR_INDEX = 0

- def _Login(self, action_runner):

- action_runner.Navigate('https://m.facebook.com/rihanna')

- action_runner.tab.WaitForDocumentReadyStateToBeComplete()

-class FacebookDesktopStory(_MediaBrowsingStory):

- NAME = 'browse:media:facebook'

+class FacebookPhotosDesktopStory(_MediaBrowsingStory):

+ NAME = 'browse:media:facebook_photos'

URL = (

'https://www.facebook.com/rihanna/photos/a.207477806675.138795.10092511675/10153911739606676/?type=3&theater')

ITEM_SELECTOR = '.snowliftPager.next'

@@ -303,7 +299,3 @@ class FacebookDesktopStory(_MediaBrowsingStory):

# theater viewer.

SUPPORTED_PLATFORMS = platforms.NO_PLATFORMS

IS_SINGLE_PAGE_APP = True

- def _Login(self, action_runner):

- action_runner.Navigate('https://www.facebook.com/rihanna')

- action_runner.tab.WaitForDocumentReadyStateToBeComplete()