Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2235773002: chromium: run GN in the checkout directory (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromium: run GN in the checkout directory BUG=584079, 593999 Recipe-Tryjob-Bypass-Reason: downstream changes expected and looking good Committed: https://chromium.googlesource.com/chromium/tools/build/+/95bc8c1803fc7a9dc409e6cdaa20c69001346cf2

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/cronet/example.expected/gn_test.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_debug__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux64_release__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_debug__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac64_release__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_debug__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_win64_release__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_gn.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_gn_rel.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gn.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_gn_rel.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_gn_rel.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_gn_rel.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_rel.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__gn_.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_dbg.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_dbg.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_gn_rel.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Paweł Hajdan Jr.
Example error: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/13067/steps/gn/logs/stdio : gn.py: Could not find gn executable at: /b/buildtools/linux64/gn
4 years, 4 months ago (2016-08-10 14:07:56 UTC) #2
kjellander_chromium
lgtm
4 years, 4 months ago (2016-08-10 14:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235773002/1
4 years, 4 months ago (2016-08-10 14:18:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: build-internal-recipe-downstream-tryjob on master.internal.infra.try (JOB_FAILED, https://uberchromegw.corp.google.com/i/internal.infra.try/builders/build-internal-recipe-downstream-tryjob/builds/2496)
4 years, 4 months ago (2016-08-10 14:19:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235773002/20001
4 years, 4 months ago (2016-08-10 14:26:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: build-internal-recipe-downstream-tryjob on master.internal.infra.try (JOB_FAILED, https://uberchromegw.corp.google.com/i/internal.infra.try/builders/build-internal-recipe-downstream-tryjob/builds/2497)
4 years, 4 months ago (2016-08-10 14:34:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235773002/20001
4 years, 4 months ago (2016-08-10 14:48:08 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: build-internal-recipe-downstream-tryjob on master.internal.infra.try (JOB_FAILED, https://uberchromegw.corp.google.com/i/internal.infra.try/builders/build-internal-recipe-downstream-tryjob/builds/2501)
4 years, 4 months ago (2016-08-10 14:55:58 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235773002/20001
4 years, 4 months ago (2016-08-10 14:56:53 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 15:03:45 UTC) #22
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/95bc8c1803fc7a9dc409...

Powered by Google App Engine
This is Rietveld 408576698