scripts/slave/recipe_modules/chromium/api.py - Issue 2235773002: chromium: run GN in the checkout directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2235773002: chromium: run GN in the checkout directory (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index 0c77311c74d88029fa81bdaa9394e129805d6010..b4c6bf84c0186579e64a72ad01e7605b150572ad 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -526,6 +526,8 @@ class ChromiumApi(recipe_api.RecipeApi):

if not gn_path:

gn_path = self.m.depot_tools.gn_py_path

+ kwargs.setdefault('cwd', self.m.path['checkout'])

gn_args = list(self.c.gn_args)

# TODO(dpranke): Figure out if we should use the '_x64' thing to

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/cronet/example.expected/gn_test.json » ('j') | no next file with comments »