Issue 223573002: Return MaybeHandle from NewRaw???String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223573002: Return MaybeHandle from NewRaw???String. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Return MaybeHandle from NewRaw???String. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20479

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -88 lines)			Patch
M	src/factory.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/factory.cc	View		7 chunks	+20 lines, -15 lines	0 comments	Download
M	src/handles.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	src/json-parser.h	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	src/json-stringifier.h	View		4 chunks	+11 lines, -11 lines	0 comments	Download
M	src/runtime.cc	View	1	11 chunks	+44 lines, -42 lines	0 comments	Download
M	src/uri.h	View		5 chunks	+11 lines, -11 lines	0 comments	Download
M	test/cctest/test-mementos.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/223573002/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/223573002/diff/1/src/runtime.cc#newcode3967 src/runtime.cc:3967: Handle<SeqString> untyped_res; I would put ...

6 years, 8 months ago (2014-04-03 10:09:08 UTC) #2

Yang

6 years, 8 months ago (2014-04-03 12:30:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20479 (presubmit successful).

Expand Messages | Collapse Messages

Issue 223573002: Return MaybeHandle from NewRaw???String. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages