Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: test/cctest/test-mementos.cc

Issue 223573002: Return MaybeHandle from NewRaw???String. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/uri.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 21 matching lines...) Expand all
32 32
33 static void SetUpNewSpaceWithPoisonedMementoAtTop() { 33 static void SetUpNewSpaceWithPoisonedMementoAtTop() {
34 Isolate* isolate = CcTest::i_isolate(); 34 Isolate* isolate = CcTest::i_isolate();
35 Heap* heap = isolate->heap(); 35 Heap* heap = isolate->heap();
36 NewSpace* new_space = heap->new_space(); 36 NewSpace* new_space = heap->new_space();
37 37
38 // Make sure we can allocate some objects without causing a GC later. 38 // Make sure we can allocate some objects without causing a GC later.
39 heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask); 39 heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
40 40
41 // Allocate a string, the GC may suspect a memento behind the string. 41 // Allocate a string, the GC may suspect a memento behind the string.
42 Handle<SeqOneByteString> string = isolate->factory()->NewRawOneByteString(12); 42 Handle<SeqOneByteString> string =
43 isolate->factory()->NewRawOneByteString(12).ToHandleChecked();
43 CHECK(*string); 44 CHECK(*string);
44 45
45 // Create an allocation memento behind the string with a garbage allocation 46 // Create an allocation memento behind the string with a garbage allocation
46 // site pointer. 47 // site pointer.
47 AllocationMemento* memento = 48 AllocationMemento* memento =
48 reinterpret_cast<AllocationMemento*>(new_space->top() + kHeapObjectTag); 49 reinterpret_cast<AllocationMemento*>(new_space->top() + kHeapObjectTag);
49 memento->set_map_no_write_barrier(heap->allocation_memento_map()); 50 memento->set_map_no_write_barrier(heap->allocation_memento_map());
50 memento->set_allocation_site( 51 memento->set_allocation_site(
51 reinterpret_cast<AllocationSite*>(kHeapObjectTag), SKIP_WRITE_BARRIER); 52 reinterpret_cast<AllocationSite*>(kHeapObjectTag), SKIP_WRITE_BARRIER);
52 } 53 }
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 AllocationMemento* memento = 115 AllocationMemento* memento =
115 reinterpret_cast<AllocationMemento*>(memento_address + kHeapObjectTag); 116 reinterpret_cast<AllocationMemento*>(memento_address + kHeapObjectTag);
116 CHECK_EQ(memento->map(), heap->allocation_memento_map()); 117 CHECK_EQ(memento->map(), heap->allocation_memento_map());
117 118
118 // Furthermore, how many mementos did we create? The count should match 119 // Furthermore, how many mementos did we create? The count should match
119 // call_count - SharedFunctionInfo::kGenerousAllocationCount. 120 // call_count - SharedFunctionInfo::kGenerousAllocationCount.
120 AllocationSite* site = memento->GetAllocationSite(); 121 AllocationSite* site = memento->GetAllocationSite();
121 CHECK_EQ(call_count - SharedFunctionInfo::kGenerousAllocationCount, 122 CHECK_EQ(call_count - SharedFunctionInfo::kGenerousAllocationCount,
122 site->pretenure_create_count()->value()); 123 site->pretenure_create_count()->value());
123 } 124 }
OLDNEW
« no previous file with comments | « src/uri.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698