Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 2235703004: [turbofan] Disable store elimination, which is suspected to cause test flakes. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Michael Hablich, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable store elimination, which is suspected to cause test flakes. BUG=v8:5280 Committed: https://crrev.com/b70e73d8d6694408bc850a986476e5bf59f7de91 Cr-Commit-Position: refs/heads/master@{#38557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
bgeron
TBR.
4 years, 4 months ago (2016-08-10 17:17:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235703004/1
4 years, 4 months ago (2016-08-10 17:17:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-10 17:17:48 UTC) #5
bgeron
4 years, 4 months ago (2016-08-10 17:18:19 UTC) #7
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-10 17:23:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235703004/1
4 years, 4 months ago (2016-08-10 17:40:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 18:27:05 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:27:26 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b70e73d8d6694408bc850a986476e5bf59f7de91
Cr-Commit-Position: refs/heads/master@{#38557}

Powered by Google App Engine
This is Rietveld 408576698