Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2236443006:
[turbofan] Instead of using properties, use a whitelist for store-store elimination. (Closed)
Description[turbofan] Instead of using properties, use a whitelist for store-store elimination. Make --turbo imply --turbo-store-elimination, so it is tested by ClusterFuzz.
This should fix bug v8:5280.
BUG=v8:5280
Committed: https://crrev.com/f1f7222842fe16df9eee3f1fe81efc086fd6e5c4
Cr-Commit-Position: refs/heads/master@{#38649}
Patch Set 1 #Patch Set 2 : Also reenable --turbo-store-elimination by default. #Patch Set 3 : Do not rely on operators for knowing that stores can be eliminated; use an operator whitelist. #Patch Set 4 : Merge with master. This should fix the failing test. #Patch Set 5 : Get rid of blacklist. Put Retain in whitelist. #Patch Set 6 : Don't enable --turbo-store-elimination by default, but have it implied from --turbo. #Messages
Total messages: 38 (29 generated)
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [turbofan] Do not do store-store elimination across Allocate. This fixes bug v8:5280. BUG=v8:5280 ========== to ========== [turbofan] Do not do store-store elimination across Allocate. Reenable --turbo-store-elimination. This fixes bug v8:5280. BUG=v8:5280 ==========
bgeron@google.com changed reviewers: + jarin@chromium.org
Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bgeron@google.com to run a CQ dry run
The CQ bit was unchecked by bgeron@google.com
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL.
Description was changed from ========== [turbofan] Do not do store-store elimination across Allocate. Reenable --turbo-store-elimination. This fixes bug v8:5280. BUG=v8:5280 ========== to ========== [turbofan] Instead of using properties, use a whitelist for store-store elimination. Reenable --turbo-store-elimination. This should fix bug v8:5280. BUG=v8:5280 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
On 2016/08/11 13:02:46, bgeron wrote: > PTAL. The Windows test seems to fail because of out of memory.
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The failing subtest was apparently disabled in https://codereview.chromium.org/2236393002 by machenbach because it was too slow on many targets.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Get rid of blacklist. Put Retain in whitelist.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [turbofan] Instead of using properties, use a whitelist for store-store elimination. Reenable --turbo-store-elimination. This should fix bug v8:5280. BUG=v8:5280 ========== to ========== [turbofan] Instead of using properties, use a whitelist for store-store elimination. Make --turbo imply --turbo-store-elimination, so it is tested by ClusterFuzz. This should fix bug v8:5280. BUG=v8:5280 ==========
The CQ bit was checked by bgeron@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bgeron@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Instead of using properties, use a whitelist for store-store elimination. Make --turbo imply --turbo-store-elimination, so it is tested by ClusterFuzz. This should fix bug v8:5280. BUG=v8:5280 ========== to ========== [turbofan] Instead of using properties, use a whitelist for store-store elimination. Make --turbo imply --turbo-store-elimination, so it is tested by ClusterFuzz. This should fix bug v8:5280. BUG=v8:5280 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Instead of using properties, use a whitelist for store-store elimination. Make --turbo imply --turbo-store-elimination, so it is tested by ClusterFuzz. This should fix bug v8:5280. BUG=v8:5280 ========== to ========== [turbofan] Instead of using properties, use a whitelist for store-store elimination. Make --turbo imply --turbo-store-elimination, so it is tested by ClusterFuzz. This should fix bug v8:5280. BUG=v8:5280 Committed: https://crrev.com/f1f7222842fe16df9eee3f1fe81efc086fd6e5c4 Cr-Commit-Position: refs/heads/master@{#38649} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/f1f7222842fe16df9eee3f1fe81efc086fd6e5c4 Cr-Commit-Position: refs/heads/master@{#38649} |
