Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 2235693003: Making sure logging in minidump unittest is aware when string is none. (Closed)

Created:
4 years, 4 months ago by eyaich
Modified:
4 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making sure logging in minidump unittest is aware when string is none. BUG=chromium:633761 Committed: https://crrev.com/170b679ea057ed27c7f7ed6785208a7b0b512cd6 Cr-Commit-Position: refs/heads/master@{#411119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M tools/perf/core/minidump_unittest.py View 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
eyaich
4 years, 4 months ago (2016-08-10 14:40:56 UTC) #2
nednguyen
lgtm
4 years, 4 months ago (2016-08-10 14:45:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235693003/1
4 years, 4 months ago (2016-08-10 14:53:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/49462)
4 years, 4 months ago (2016-08-10 15:15:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235693003/1
4 years, 4 months ago (2016-08-10 17:52:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 19:42:47 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:45:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/170b679ea057ed27c7f7ed6785208a7b0b512cd6
Cr-Commit-Position: refs/heads/master@{#411119}

Powered by Google App Engine
This is Rietveld 408576698