Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: tools/perf/core/minidump_unittest.py

Issue 2235693003: Making sure logging in minidump unittest is aware when string is none. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/minidump_unittest.py
diff --git a/tools/perf/core/minidump_unittest.py b/tools/perf/core/minidump_unittest.py
index 13c49d3151121a50ca73333469e27751058819f2..4caf97ff7d3530f7143e01bd649417e4de3bdaf5 100644
--- a/tools/perf/core/minidump_unittest.py
+++ b/tools/perf/core/minidump_unittest.py
@@ -19,8 +19,9 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
crash_minidump_path = self._browser.GetMostRecentMinidumpPath()
#self.assertIsNotNone(crash_minidump_path)
- logging.info('testSymbolizeMinidump: most recent path = '
- + crash_minidump_path)
+ if crash_minidump_path is not None:
+ logging.info('testSymbolizeMinidump: most recent path = '
+ + crash_minidump_path)
all_paths = self._browser.GetAllMinidumpPaths()
logging.info('testSymbolizeMinidump: all paths ' + ''.join(all_paths))
all_unsymbolized_paths = self._browser.GetAllUnsymbolizedMinidumpPaths()
@@ -41,7 +42,6 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
@decorators.Isolated
@decorators.Enabled('mac')
- @decorators.Disabled('mac') # crbug.com/634156
def testMultipleCrashMinidumps(self):
# Wait for the browser to restart fully before crashing
self._LoadPageThenWait('var cat = "dog";', 'cat')
@@ -49,8 +49,9 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
first_crash_path = self._browser.GetMostRecentMinidumpPath()
#self.assertIsNotNone(first_crash_path)
- logging.info('testMultipleCrashMinidumps: first crash most recent path'
- + first_crash_path)
+ if first_crash_path is not None:
+ logging.info('testMultipleCrashMinidumps: first crash most recent path'
+ + first_crash_path)
all_paths = self._browser.GetAllMinidumpPaths()
logging.info('testMultipleCrashMinidumps: first crash all paths: '
+ ''.join(all_paths))
@@ -70,8 +71,9 @@ class BrowserMinidumpTest(tab_test_case.TabTestCase):
self._browser.tabs.New().Navigate('chrome://gpucrash', timeout=5)
second_crash_path = self._browser.GetMostRecentMinidumpPath()
#self.assertIsNotNone(second_crash_path)
- logging.info('testMultipleCrashMinidumps: second crash most recent path'
- + second_crash_path)
+ if second_crash_path is not None:
+ logging.info('testMultipleCrashMinidumps: second crash most recent path'
+ + second_crash_path)
second_crash_all_paths = self._browser.GetAllMinidumpPaths()
logging.info('testMultipleCrashMinidumps: second crash all paths: '
+ ''.join(second_crash_all_paths))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698