Chromium Code Reviews Chromium Code Reviews
Issue 2235693002:
convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html |
| diff --git a/third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html b/third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html |
| index 941e9f53ea531872a701bfc64c0be96006bf24b3..7298e51eb32234411add7631f12e468f7397c005 100644 |
| --- a/third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html |
| +++ b/third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html |
| @@ -1,17 +1,20 @@ |
| <!DOCTYPE html> |
| -<script src="../resources/js-test.js"></script> |
| +<head> |
|
Srirama
2016/08/10 11:04:38
nit: html, head and body elements are options, so
MuVen
2016/08/10 11:40:58
On 2016/08/10 11:04:38, Srirama wrote:
> nit: html
|
| +<title>Make sure a parent block that fits content expands when a child adds an auto scrollbar.</title> |
| +</head> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| <div id="top" style="float:left; display:none;"> |
| <div id="scroller" style="overflow: auto; height: 100px;"> |
| <div style="width: 100px; height: 200px; border: 2px solid blue;"></div> |
| </div> |
| </div> |
| - |
| <script> |
| -description("Make sure a parent block that fits content expands when a child adds an auto scrollbar."); |
| - |
| -var topDiv = document.getElementById("top"); |
| -var scroller = document.getElementById("scroller"); |
| -topDiv.style.display = "block"; |
| -topDiv.offsetTop; |
| -shouldBe("scroller.clientWidth", "scroller.scrollWidth"); |
| +test(function(){ |
|
Srirama
2016/08/10 11:04:39
nit: add space between () and {
MuVen
2016/08/10 11:40:59
Done.
|
| + var topDiv = document.getElementById("top"); |
| + var scroller = document.getElementById("scroller"); |
| + topDiv.style.display = "block"; |
| + topDiv.offsetTop; |
| + assert_equals(scroller.clientWidth, scroller.scrollWidth); |
| +}); |
| </script> |
