Issue 22356002: Revert 215745 "Fix crash when reloading packaged app. "

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22356002: Revert 215745 "Fix crash when reloading packaged app. " (Closed)

Created:
7 years, 4 months ago by benwells

Modified:
7 years, 4 months ago

Reviewers:
benwells

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 215745 "Fix crash when reloading packaged app. " > Fix crash when reloading packaged app. > > When a shell window was closed, it wasn't removed from the registry immediately > (it was removed in a callback from OnNativeClose, which happens a bit later.) > This meant that when the app was loaded again, the window was still in the > registry with a stale pointer to the old extension. ExtensionSettingsHandler > was tickling this by iterating shell windows on extension load. > > BUG=174250 > TEST=On chromeos, enable the 'Enable debugging for packed apps.' flag. Then > open chrome://extensions. Then open a packaged app, and reload it. Chrome > should not crash. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214844 > > Review URL: https://chromiumcodereview.appspot.com/20243003 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215782

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -66 lines)			Patch
M	trunk/src/apps/shell_window.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	trunk/src/apps/shell_window.cc	View	4 chunks	+7 lines, -22 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/platform_app_browsertest.cc	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/shell_window_registry.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc	View	2 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r215782.

Expand Messages | Collapse Messages