Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: trunk/src/chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm

Issue 22356002: Revert 215745 "Fix crash when reloading packaged app. " (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm
===================================================================
--- trunk/src/chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm (revision 215781)
+++ trunk/src/chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm (working copy)
@@ -4,10 +4,8 @@
#include "chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.h"
-#include "base/bind.h"
#include "base/command_line.h"
#include "base/mac/mac_util.h"
-#include "base/message_loop/message_loop.h"
#include "base/strings/sys_string_conversions.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/cocoa/browser_window_utils.h"
@@ -760,13 +758,7 @@
void NativeAppWindowCocoa::WindowWillClose() {
[window_controller_ setAppWindow:NULL];
shell_window_->OnNativeWindowChanged();
- // On other platforms, the native window doesn't get destroyed synchronously.
- // We simulate that here so that ShellWindow can assume that it doesn't get
- // deleted immediately upon calling Close().
- base::MessageLoop::current()->PostTask(
- FROM_HERE,
- base::Bind(&ShellWindow::OnNativeClose,
- base::Unretained(shell_window_)));
+ shell_window_->OnNativeClose();
}
void NativeAppWindowCocoa::WindowDidBecomeKey() {

Powered by Google App Engine
This is Rietveld 408576698