Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2235543002: Keep track of how many documents had a resource intercepted by foreign fetch. (Closed)

Created:
4 years, 4 months ago by Marijn Kruisselbrink
Modified:
4 years, 4 months ago
Reviewers:
michaeln, Mark P, pfeldman
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, horo+watch_chromium.org, jam, Nate Chapin, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, loading-reviews_chromium.org, michaeln, nhiroki, serviceworker-reviews, tyoshino+watch_chromium.org, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep track of how many documents had a resource intercepted by foreign fetch. BUG=540509 Committed: https://crrev.com/aab8f4ad7ece5daebebba87d9e7eb3a0ebb3ae79 Cr-Commit-Position: refs/heads/master@{#413303}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M content/browser/service_worker/service_worker_response_info.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_response_info.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/resource_response.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/resource_response_info.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/resource_response_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLResponse.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 3 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (23 generated)
Marijn Kruisselbrink
michaeln: would you mind taking a look at this before I try to find OWNERS ...
4 years, 4 months ago (2016-08-17 20:05:47 UTC) #14
michaeln
lgtm
4 years, 4 months ago (2016-08-17 23:07:30 UTC) #17
Marijn Kruisselbrink
+pfeldman for content and blink OWNERS +mpearson for histograms OWNERS
4 years, 4 months ago (2016-08-17 23:41:47 UTC) #19
Mark P
histograms.xml lgtm
4 years, 4 months ago (2016-08-18 16:16:27 UTC) #20
pfeldman
lgtm
4 years, 4 months ago (2016-08-19 18:29:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235543002/40001
4 years, 4 months ago (2016-08-19 18:36:01 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/115470) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-19 18:39:40 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235543002/60001
4 years, 4 months ago (2016-08-19 18:43:55 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/277293)
4 years, 4 months ago (2016-08-19 23:25:38 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235543002/60001
4 years, 4 months ago (2016-08-19 23:27:19 UTC) #32
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 4 months ago (2016-08-20 01:14:03 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 01:15:24 UTC) #35
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aab8f4ad7ece5daebebba87d9e7eb3a0ebb3ae79
Cr-Commit-Position: refs/heads/master@{#413303}

Powered by Google App Engine
This is Rietveld 408576698