Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 2235543002: Keep track of how many documents had a resource intercepted by foreign fetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index c69bc87efbda43e9e323c6b7e8319970108d142e..9f97c27f56a568142d80905c0d918d2800f71365 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -978,6 +978,7 @@ void ServiceWorkerURLRequestJob::OnStartCompleted() const {
ServiceWorkerResponseInfo::ForRequest(request_, true)
->OnStartCompleted(
false /* was_fetched_via_service_worker */,
+ false /* was_fetched_via_foreign_fetch */,
false /* was_fallback_required */,
GURL() /* original_url_via_service_worker */,
blink::WebServiceWorkerResponseTypeDefault,
@@ -990,9 +991,10 @@ void ServiceWorkerURLRequestJob::OnStartCompleted() const {
}
ServiceWorkerResponseInfo::ForRequest(request_, true)
->OnStartCompleted(
- true /* was_fetched_via_service_worker */, fall_back_required_,
- response_url_, service_worker_response_type_, worker_start_time_,
- worker_ready_time_, response_is_in_cache_storage_,
+ true /* was_fetched_via_service_worker */,
+ fetch_type_ == ServiceWorkerFetchType::FOREIGN_FETCH,
+ fall_back_required_, response_url_, service_worker_response_type_,
+ worker_start_time_, worker_ready_time_, response_is_in_cache_storage_,
response_cache_storage_cache_name_, cors_exposed_header_names_);
}
« no previous file with comments | « content/browser/service_worker/service_worker_response_info.cc ('k') | content/child/web_url_loader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698