Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: pkg/smoke/lib/src/default_transformer.dart

Issue 223553008: Only pass an AssetId to isPrimary and declareOutputs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix script_compactor Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | pkg/smoke/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/smoke/lib/src/default_transformer.dart
diff --git a/pkg/smoke/lib/src/default_transformer.dart b/pkg/smoke/lib/src/default_transformer.dart
index 49962a9146ac5b623a12cf29b2414d7ca75a02e2..2a7d9ec084c7bbb59f39083824505e4b5fa395c7 100644
--- a/pkg/smoke/lib/src/default_transformer.dart
+++ b/pkg/smoke/lib/src/default_transformer.dart
@@ -17,9 +17,13 @@ class DefaultTransformer extends Transformer {
DefaultTransformer.asPlugin();
/// Only apply to `lib/src/implementation.dart`.
- Future<bool> isPrimary(Asset input) => new Future.value(
- input.id.package == 'smoke' &&
- input.id.path == 'lib/src/implementation.dart');
+ // TODO(nweiz): This should just take an AssetId when barback <0.13.0 support
+ // is dropped.
+ Future<bool> isPrimary(idOrAsset) {
+ var id = idOrAsset is AssetId ? idOrAsset : idOrAsset.id;
+ return new Future.value(
+ id.package == 'smoke' && id.path == 'lib/src/implementation.dart');
+ }
Future apply(Transform transform) {
var id = transform.primaryInput.id;
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | pkg/smoke/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698