Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: pkg/smoke/lib/src/default_transformer.dart

Issue 223553008: Only pass an AssetId to isPrimary and declareOutputs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix script_compactor Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | pkg/smoke/pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Transformer that replaces the default mirror-based implementation of smoke, 5 /// Transformer that replaces the default mirror-based implementation of smoke,
6 /// so that during deploy smoke doesn't include any dependency on dart:mirrors. 6 /// so that during deploy smoke doesn't include any dependency on dart:mirrors.
7 library smoke.src.default_transformer; 7 library smoke.src.default_transformer;
8 8
9 import 'dart:async'; 9 import 'dart:async';
10 import 'package:barback/barback.dart'; 10 import 'package:barback/barback.dart';
11 11
12 /// Replaces the default mirror-based implementation of smoke in 12 /// Replaces the default mirror-based implementation of smoke in
13 /// `pacakge:smoke/implementation.dart`, so that during deploy smoke doesn't 13 /// `pacakge:smoke/implementation.dart`, so that during deploy smoke doesn't
14 /// include any dependency on dart:mirrors. 14 /// include any dependency on dart:mirrors.
15 // TODO(sigmund): include tests that run this transformation automatically. 15 // TODO(sigmund): include tests that run this transformation automatically.
16 class DefaultTransformer extends Transformer { 16 class DefaultTransformer extends Transformer {
17 DefaultTransformer.asPlugin(); 17 DefaultTransformer.asPlugin();
18 18
19 /// Only apply to `lib/src/implementation.dart`. 19 /// Only apply to `lib/src/implementation.dart`.
20 Future<bool> isPrimary(Asset input) => new Future.value( 20 // TODO(nweiz): This should just take an AssetId when barback <0.13.0 support
21 input.id.package == 'smoke' && 21 // is dropped.
22 input.id.path == 'lib/src/implementation.dart'); 22 Future<bool> isPrimary(idOrAsset) {
23 var id = idOrAsset is AssetId ? idOrAsset : idOrAsset.id;
24 return new Future.value(
25 id.package == 'smoke' && id.path == 'lib/src/implementation.dart');
26 }
23 27
24 Future apply(Transform transform) { 28 Future apply(Transform transform) {
25 var id = transform.primaryInput.id; 29 var id = transform.primaryInput.id;
26 return transform.primaryInput.readAsString().then((code) { 30 return transform.primaryInput.readAsString().then((code) {
27 // Note: this rewrite is highly-coupled with how implementation.dart is 31 // Note: this rewrite is highly-coupled with how implementation.dart is
28 // written. Make sure both are updated in sync. 32 // written. Make sure both are updated in sync.
29 transform.addOutput(new Asset.fromString(id, code 33 transform.addOutput(new Asset.fromString(id, code
30 .replaceAll(new RegExp('new Reflective[^;]*;'), 34 .replaceAll(new RegExp('new Reflective[^;]*;'),
31 'throwNotConfiguredError();') 35 'throwNotConfiguredError();')
32 .replaceAll("import 'package:smoke/mirrors.dart';", ''))); 36 .replaceAll("import 'package:smoke/mirrors.dart';", '')));
33 }); 37 });
34 } 38 }
35 } 39 }
36 40
37 /** Transformer phases which should be applied to the smoke package. */ 41 /** Transformer phases which should be applied to the smoke package. */
38 List<List<Transformer>> get phasesForSmoke => 42 List<List<Transformer>> get phasesForSmoke =>
39 [[new DefaultTransformer.asPlugin()]]; 43 [[new DefaultTransformer.asPlugin()]];
OLDNEW
« no previous file with comments | « pkg/polymer/pubspec.yaml ('k') | pkg/smoke/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698