Fix ScopedNSObject tests to deal with selection of ScopedTypeRef::get().

Fix ScopedNSObject tests to deal with selection of ScopedTypeRef::get().

As the same binary links both scoped_nsobject_unittest{,_arc}.o objects
files, there are at least two implementation of that method, one compiled
without ARC and one compiled with ARC. Depending on the order of object
files on the linker command-line the implementation selected may change.

The non-ARC version does not contains any call to retain/release while the
ARC version does call objc_retainAutoreleaseAndReturn. Those are functionally
equivalent the retain/release calls are balanced, but the ARC version cause
the refcount to be increased until the current autorelease pool is released.

Putting the "p3 = p1;" in a separate block with an explicit auto-release pool
drain fix the test in all configurations.

BUG=637065
Committed: https://crrev.com/269f2a7139aa0df611b294d0d4e23b6ca4791915
Cr-Commit-Position: refs/heads/master@{#411730}

[sdefresne, 2016-08-11 20:24:11]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-08-11 20:24:20]

sdefresne@chromium.org changed reviewers:
+ mark@chromium.org

[sdefresne, 2016-08-11 20:24:20]

Please take a look.

[commit-bot: I haz the power, 2016-08-11 20:24:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 22:01:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:01:51]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2016-08-12 17:59:35]

LGTM

[sdefresne, 2016-08-12 19:21:08]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-08-12 19:21:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 19:25:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 19:26:56]

Description was changed from

==========
Fix ScopedNSObject tests to deal with selection of ScopedTypeRef::get().

As the same binary links both scoped_nsobject_unittest{,_arc}.o objects
files, there are at least two implementation of that method, one compiled
without ARC and one compiled with ARC. Depending on the order of object
files on the linker command-line the implementation selected may change.

The non-ARC version does not contains any call to retain/release while the
ARC version does call objc_retainAutoreleaseAndReturn. Those are functionally
equivalent the retain/release calls are balanced, but the ARC version cause
the refcount to be increased until the current autorelease pool is released.

Putting the "p3 = p1;" in a separate block with an explicit auto-release pool
drain fix the test in all configurations.

BUG=637065
==========

to

==========
Fix ScopedNSObject tests to deal with selection of ScopedTypeRef::get().

As the same binary links both scoped_nsobject_unittest{,_arc}.o objects
files, there are at least two implementation of that method, one compiled
without ARC and one compiled with ARC. Depending on the order of object
files on the linker command-line the implementation selected may change.

The non-ARC version does not contains any call to retain/release while the
ARC version does call objc_retainAutoreleaseAndReturn. Those are functionally
equivalent the retain/release calls are balanced, but the ARC version cause
the refcount to be increased until the current autorelease pool is released.

Putting the "p3 = p1;" in a separate block with an explicit auto-release pool
drain fix the test in all configurations.

BUG=637065

Committed: https://crrev.com/269f2a7139aa0df611b294d0d4e23b6ca4791915
Cr-Commit-Position: refs/heads/master@{#411730}
==========

[commit-bot: I haz the power, 2016-08-12 19:26:57]

Patchset 1 (id:??) landed as
https://crrev.com/269f2a7139aa0df611b294d0d4e23b6ca4791915
Cr-Commit-Position: refs/heads/master@{#411730}