base/mac/scoped_nsobject_unittest.mm - Issue 2235353003: Fix ScopedNSObject tests to deal with selection of ScopedTypeRef::get().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/mac/scoped_nsobject_unittest.mm

Issue 2235353003: Fix ScopedNSObject tests to deal with selection of ScopedTypeRef::get(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/mac/scoped_nsobject_unittest.mm

diff --git a/base/mac/scoped_nsobject_unittest.mm b/base/mac/scoped_nsobject_unittest.mm

index cefb5fe19fbb29ac1f0a91667497b13f353a3fe4..5694e6862f607c32c3918315ad93953df437aa42 100644

--- a/base/mac/scoped_nsobject_unittest.mm

+++ b/base/mac/scoped_nsobject_unittest.mm

@@ -32,7 +32,10 @@ TEST(ScopedNSObjectTest, ScopedNSObject) {

base::scoped_nsobject<NSObject> p3 = p1;

ASSERT_EQ(p1.get(), p3.get());

ASSERT_EQ(2u, [p1 retainCount]);

- p3 = p1;

+ {

+ base::mac::ScopedNSAutoreleasePool pool;

+ p3 = p1;

+ }

ASSERT_EQ(p1.get(), p3.get());

ASSERT_EQ(2u, [p1 retainCount]);

}

« no previous file with comments | « no previous file | base/mac/scoped_nsobject_unittest_arc.mm » ('j') | no next file with comments »