arc: Support managed Arc and managed Location Service and B&R consents.

arc: Support managed Arc and managed Location Service and B&R consents.

Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.

TEST=Manually on device.
BUG=b/30469058
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e5a7ff50b3c0cb72e06a3ea7af481d7f41f872a9
Cr-Commit-Position: refs/heads/master@{#412578}

[khmel, 2016-08-11 16:51:17]

Description was changed from

==========
arc: Support managed Arc and managed Location Service and B&R consents.

Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.

TEST=Manually on device.
BUG=b/30469058
==========

to

==========
arc: Support managed Arc and managed Location Service and B&R consents.

Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.

TEST=Manually on device.
BUG=b/30469058
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[khmel, 2016-08-11 17:19:53]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-08-11 17:19:54]

Hi Xiyuan,

This work was started by Philipp here:
https://codereview.chromium.org/2225933002.

I split original CL int 2 CLs, one for policy declaration, second is UI change.

This is UI portion. I refactored code to follow common style in our code, added
listeners on pref change (now they can be changed externally and we have to
support it). Fixed layout issues when ToS are hidden, discarded 'managed by
admin' icon (it is not allowed here. I confirmed this with our PM and designer)
and added applying these options on each Arc start if they are managed.


PTAL

[xiyuan, 2016-08-11 20:01:11]

lgtm

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/background.js (right):

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:184: function
setBackupRestoreMode(defaultCheckValue, isManaged) {
nit: defaultCheckValue -> enabled, since this is the actual enabled state rather
than the default initial value now.

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:197: function
setLocationServiceMode(defaultCheckValue, isManaged) {
nit: defaultCheckValue -> enabled

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/main.html (right):

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/main.html:61: <p
class="text-terms-title" id="terms-title" i18n-content="termsOfService"></p>
nit: wrap

[khmel, 2016-08-12 20:33:24]

Thanks Xiyuan for review.

I found that I missed important things.
1 - in case managed arc we can skip loading ToS. This would reduce chance for an
error and increase optin speed.
2. policy indicators are required from task description. So I implemented them,
placing it between text and learn more link (similar style as 'Enable Android
apps' in settings.

PTAL

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/background.js (right):

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:184: function
setBackupRestoreMode(defaultCheckValue, isManaged) {
On 2016/08/11 20:01:11, xiyuan wrote:
> nit: defaultCheckValue -> enabled, since this is the actual enabled state
rather
> than the default initial value now.

Done.

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:197: function
setLocationServiceMode(defaultCheckValue, isManaged) {
On 2016/08/11 20:01:11, xiyuan wrote:
> nit: defaultCheckValue -> enabled

Done.

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/main.html (right):

https://codereview.chromium.org/2235293002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/main.html:61: <p
class="text-terms-title" id="terms-title" i18n-content="termsOfService"></p>
On 2016/08/11 20:01:11, xiyuan wrote:
> nit: wrap

Done.

https://codereview.chromium.org/2235293002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/background.js (right):

https://codereview.chromium.org/2235293002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/background.js:361: if (pageDivId
== 'terms') {
Now showing 'terms' is called from 2 places. So I added updateTermsHeight here
in order not to duplicate code.

https://codereview.chromium.org/2235293002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/arc_support/main.css (right):

https://codereview.chromium.org/2235293002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/main.css:43: .bubble-button > div
{
we have text for option smaller than in settings. So here I have to scale down
this indicator and re-position it to look correctly.

https://codereview.chromium.org/2235293002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/arc_support/main.css:81:
.controlled-setting-indicator {
Same as before

[xiyuan, 2016-08-15 17:15:07]

lgtm

[khmel, 2016-08-17 16:46:48]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2016-08-17 16:47:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 17:45:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 17:52:10]

Description was changed from

==========
arc: Support managed Arc and managed Location Service and B&R consents.

Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.

TEST=Manually on device.
BUG=b/30469058
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
arc: Support managed Arc and managed Location Service and B&R consents.

Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.

TEST=Manually on device.
BUG=b/30469058
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e5a7ff50b3c0cb72e06a3ea7af481d7f41f872a9
Cr-Commit-Position: refs/heads/master@{#412578}
==========

[commit-bot: I haz the power, 2016-08-17 17:52:11]

Patchset 3 (id:??) landed as
https://crrev.com/e5a7ff50b3c0cb72e06a3ea7af481d7f41f872a9
Cr-Commit-Position: refs/heads/master@{#412578}