Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2225933002: Suppress ToS and reflect admin policy in ARC++ welcome screen (Closed)

Created:
4 years, 4 months ago by phweiss
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress ToS and reflect admin policy in ARC++ welcome screen If an account is managed and ARC++ is enabled, the account's admin has to agree to the Terms of Service, so we do not need to show them to the user. The checkboxes on the welcome screen about Backup and Geolocation are disabled if the policies ArcBackupRestoreEnabled and DefaultGeolocationSetting already determine their value. BUG= b/30469058 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ------------------------------------- CL was split and landed by khmel, see comments.

Patch Set 1 #

Patch Set 2 : Add OS_CHROMEOS checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -12 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_service.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/policy/default_geolocation_policy_handler.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/policy/default_geolocation_policy_handler.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/policy/default_geolocation_policy_handler_unittest.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/background.js View 3 chunks +41 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/main.html View 4 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/arc_support/manifest.json View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (10 generated)
khmel
4 years, 4 months ago (2016-08-11 17:06:30 UTC) #10
On 2016/08/08 18:10:35, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I cannot update this CL

I also split this CL into 2 parts, policy declaration and UI impl.
Please follow: 
https://codereview.chromium.org/2243513002/
https://codereview.chromium.org/2235293002/

Powered by Google App Engine
This is Rietveld 408576698