ash: Refactor Shelf ownership and ShelfView creation

ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely referenced. It will be easier to remove after alignment and autohide state move to WmShelf.
* Eliminate Shelf::SetVisible() helper

BUG=615502
TEST=existing ash_unittests and chrome unit_tests

Committed: https://crrev.com/361185a2df3bfc21597d72dff241731e676885cd
Cr-Commit-Position: refs/heads/master@{#411828}

[James Cook, 2016-08-12 21:35:44]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 21:36:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-12 21:56:47]

Description was changed from

==========
WIP: ash: Refactor Shelf ownership and ShelfView creation

Move Shelf ownership to RootWindowController


Remove more Shelf from ShelfWidget and more ShelfView from Shelf


remove almost all of Shelf from ShelfWidget


Don't get ShelfModel from ShelfView, eliminate NativeView name

BUG=
==========

to

==========
ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely
referenced. It will be easier to remove after alignment and autohide state move
to WmShelf.

BUG=615502
TEST=existing ash_unittests and chrome unit_tests
==========

[James Cook, 2016-08-12 21:56:55]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 21:57:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-12 21:57:49]

Description was changed from

==========
ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely
referenced. It will be easier to remove after alignment and autohide state move
to WmShelf.

BUG=615502
TEST=existing ash_unittests and chrome unit_tests
==========

to

==========
ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely
referenced. It will be easier to remove after alignment and autohide state move
to WmShelf.
* Eliminate Shelf::SetVisible() helper

BUG=615502
TEST=existing ash_unittests and chrome unit_tests
==========

[James Cook, 2016-08-12 22:00:46]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-12 22:00:47]

msw, please take a look.

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf.cc
File ash/shelf/shelf.cc (right):

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf.cc#newc...
ash/shelf/shelf.cc:40: shelf_view_(shelf_view),
I'd like to eliminate this member, but it's a bit much to do in this CL.

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.cc:409: WmShelf* wm_shelf =
static_cast<WmShelf*>(wm_shelf_aura_);
This also sucks, but will go away after one of your CLs replaces wm_shelf_aura_
with wm_shelf_, so I didn't rearrange WmShelfAura to make it public.

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget.h
File ash/shelf/shelf_widget.h (right):

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.h:62: Shelf* shelf() { return shelf_; }
This sucks, but as I said in the CL description it is used in a bunch of place
and I'd prefer to clean it up later.

[msw, 2016-08-12 22:39:53]

lgtm; nice step in the right direction

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf.cc
File ash/shelf/shelf.cc (right):

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf.cc#newc...
ash/shelf/shelf.cc:40: shelf_view_(shelf_view),
On 2016/08/12 22:00:47, James Cook wrote:
> I'd like to eliminate this member, but it's a bit much to do in this CL.

Acknowledged.

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget.cc
File ash/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.cc:409: WmShelf* wm_shelf =
static_cast<WmShelf*>(wm_shelf_aura_);
On 2016/08/12 22:00:47, James Cook wrote:
> This also sucks, but will go away after one of your CLs replaces
wm_shelf_aura_
> with wm_shelf_, so I didn't rearrange WmShelfAura to make it public.

Acknowledged.

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget.h
File ash/shelf/shelf_widget.h (right):

https://codereview.chromium.org/2235233006/diff/40001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.h:62: Shelf* shelf() { return shelf_; }
On 2016/08/12 22:00:47, James Cook wrote:
> This sucks, but as I said in the CL description it is used in a bunch of place
> and I'd prefer to clean it up later.

Acknowledged.

[commit-bot: I haz the power, 2016-08-12 22:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:53:42]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-12 23:09:12]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-12 23:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2235233006/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-12 23:09:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 00:13:33]

Description was changed from

==========
ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely
referenced. It will be easier to remove after alignment and autohide state move
to WmShelf.
* Eliminate Shelf::SetVisible() helper

BUG=615502
TEST=existing ash_unittests and chrome unit_tests
==========

to

==========
ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely
referenced. It will be easier to remove after alignment and autohide state move
to WmShelf.
* Eliminate Shelf::SetVisible() helper

BUG=615502
TEST=existing ash_unittests and chrome unit_tests
==========

[commit-bot: I haz the power, 2016-08-13 00:13:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-13 00:18:55]

Description was changed from

==========
ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely
referenced. It will be easier to remove after alignment and autohide state move
to WmShelf.
* Eliminate Shelf::SetVisible() helper

BUG=615502
TEST=existing ash_unittests and chrome unit_tests
==========

to

==========
ash: Refactor Shelf ownership and ShelfView creation

This is a step toward replacing Shelf with WmShelf. See go/mash-shelf-refactor

* Move Shelf ownership to ash::RootWindowController
* Construct ShelfView in ShelfWidget
* Remove Shelf usage from ShelfWidget implementation
* Unfortunately, ShelfWidget::shelf() must remain for now as it is widely
referenced. It will be easier to remove after alignment and autohide state move
to WmShelf.
* Eliminate Shelf::SetVisible() helper

BUG=615502
TEST=existing ash_unittests and chrome unit_tests

Committed: https://crrev.com/361185a2df3bfc21597d72dff241731e676885cd
Cr-Commit-Position: refs/heads/master@{#411828}
==========

[commit-bot: I haz the power, 2016-08-13 00:18:56]

Patchset 4 (id:??) landed as
https://crrev.com/361185a2df3bfc21597d72dff241731e676885cd
Cr-Commit-Position: refs/heads/master@{#411828}