Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2446)

Unified Diff: ash/shelf/shelf.h

Issue 2235233006: ash: Refactor Shelf ownership and ShelfView creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/root_window_controller.cc ('k') | ash/shelf/shelf.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf.h
diff --git a/ash/shelf/shelf.h b/ash/shelf/shelf.h
index 5c6ef51c5b1b14cbe56a09dd7aa4a1f7cb3a5482..696a8f903825bea84601e5dbea6f903939c9d07e 100644
--- a/ash/shelf/shelf.h
+++ b/ash/shelf/shelf.h
@@ -35,7 +35,6 @@ class AppListButton;
class FocusCycler;
class ShelfDelegate;
class ShelfIconObserver;
-class ShelfModel;
class ShelfView;
class WmShelf;
@@ -43,15 +42,12 @@ namespace test {
class ShelfTestAPI;
}
-// Controller for shelf state. All access to state (visibility, auto-hide, etc.)
-// should occur via this class.
+// Controller for shelf state.
+// DEPRECATED: WmShelf is replacing this class as part of the mus/mash refactor.
+// Use WmShelf for access to state (visibility, auto-hide, etc.).
class ASH_EXPORT Shelf {
public:
- static const char kNativeViewName[];
-
- Shelf(ShelfModel* model,
- WmShelf* wm_shelf,
- ShelfWidget* widget);
+ Shelf(WmShelf* wm_shelf, ShelfView* shelf_view, ShelfWidget* widget);
~Shelf();
// Return the shelf for the primary display. NULL if no user is logged in yet.
@@ -64,10 +60,12 @@ class ASH_EXPORT Shelf {
// user is logged in yet.
static Shelf* ForWindow(const WmWindow* window);
+ // DEPRECATED. Use WmShelf::GetAlignment() and SetAlignment().
void SetAlignment(ShelfAlignment alignment);
ShelfAlignment alignment() const { return alignment_; }
// Sets the ShelfAutoHideBehavior. See enum description for details.
+ // DEPRECATED. Use WmShelf::GetAutoHideBehavior() and SetAutoHideBehavior().
void SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide_behavior);
ShelfAutoHideBehavior auto_hide_behavior() const {
return auto_hide_behavior_;
@@ -101,7 +99,7 @@ class ASH_EXPORT Shelf {
// TODO(jamescook): Migrate this to ShelfWidget.
bool IsShowingOverflowBubble() const;
- void SetVisible(bool visible) const;
+ // TODO(jamescook): Migrate to ShelfWidget::IsShelfVisible().
bool IsVisible() const;
void SchedulePaint();
« no previous file with comments | « ash/root_window_controller.cc ('k') | ash/shelf/shelf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698