Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2235233002: Site Settings Desktop: Add Closure coverage for Protocol Handlers. (Closed)

Created:
4 years, 4 months ago by Finnur
Modified:
4 years, 4 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Add Closure coverage for Protocol Handlers. BUG=543635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3aae373206e29352ecc767eb16e11638babc94fc Cr-Commit-Position: refs/heads/master@{#411589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/resources/settings/site_settings/compiled_resources2.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/protocol_handlers.js View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Finnur
4 years, 4 months ago (2016-08-11 15:15:38 UTC) #5
dschuyler
lgtm
4 years, 4 months ago (2016-08-11 23:53:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235233002/1
4 years, 4 months ago (2016-08-12 10:05:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 10:08:36 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 10:10:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3aae373206e29352ecc767eb16e11638babc94fc
Cr-Commit-Position: refs/heads/master@{#411589}

Powered by Google App Engine
This is Rietveld 408576698