chrome/browser/resources/settings/site_settings/protocol_handlers.js - Issue 2235233002: Site Settings Desktop: Add Closure coverage for Protocol Handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/protocol_handlers.js

Issue 2235233002: Site Settings Desktop: Add Closure coverage for Protocol Handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/protocol_handlers.js

diff --git a/chrome/browser/resources/settings/site_settings/protocol_handlers.js b/chrome/browser/resources/settings/site_settings/protocol_handlers.js

index 2f37b295087b75151802abaf539d94804360a9ab..7182f9af49ff2804ed28fe44bd8ea2f32f6b3a2d 100644

--- a/chrome/browser/resources/settings/site_settings/protocol_handlers.js

+++ b/chrome/browser/resources/settings/site_settings/protocol_handlers.js

@@ -8,6 +8,10 @@

* protocol handlers category under Site Settings.

+/**

+ * All possible actions in the menu.

+ * @enum {string}

+ */

var MenuActions = {

SET_DEFAULT: 'SetDefault',

REMOVE: 'Remove',

@@ -69,7 +73,7 @@ Polymer({

/**

* Obtains the description for the main toggle.

- * @param {number} categoryEnabled Whether the main toggle is enabled.

+ * @param {boolean} categoryEnabled Whether the main toggle is enabled.

* @return {string} The description to use.

* @private

@@ -128,6 +132,8 @@ Polymer({

/**

* A handler when an action is selected in the action menu.

+ * @param {!{model: !{item: ProtocolHandlerEntry},

+ * detail: !{selected: string}}} event

* @private

onActionMenuIronActivate_: function(event) {