Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2235163002: WebRTC: Don't use remote_run for tryserver.webrtc ios recipes. (Closed)

Created:
4 years, 4 months ago by kjellander_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Don't use remote_run for tryserver.webrtc ios recipes. This was turned on by mistake in https://codereview.chromium.org/2222163004 for too many recipes: the webrtc/ios and webrtc/ios_api_framework recipes are not working with remote_run currently. BUG=584079, 593999 TBR=phajdan.jr@chromium.org, ehmaldonado@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/8d243d31a316fcbdfb0e5dba1d5ae75c358e354f

Patch Set 1 #

Patch Set 2 : Handling missing recipe key #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M masters/master.tryserver.webrtc/master.cfg View 1 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
kjellander_chromium
This should fix our ios trybots.
4 years, 4 months ago (2016-08-11 06:38:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235163002/1
4 years, 4 months ago (2016-08-11 06:38:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/309124af431f2510)
4 years, 4 months ago (2016-08-11 06:45:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235163002/20001
4 years, 4 months ago (2016-08-11 06:53:38 UTC) #8
kjellander_chromium
https://codereview.chromium.org/2235163002/diff/20001/masters/master.tryserver.webrtc/master.cfg File masters/master.tryserver.webrtc/master.cfg (right): https://codereview.chromium.org/2235163002/diff/20001/masters/master.tryserver.webrtc/master.cfg#newcode142 masters/master.tryserver.webrtc/master.cfg:142: if spec.get('recipe', 'webrtc/standalone') != 'webrtc/standalone' I admit this is ...
4 years, 4 months ago (2016-08-11 06:54:57 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 07:00:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/8d243d31a316fcbdfb0e...

Powered by Google App Engine
This is Rietveld 408576698